Closed Bug 1601345 Opened 2 years ago Closed 2 years ago

Remove containers panel's "<< Go Back" text link in favor of a back button, like in about:addons

Categories

(Firefox :: Preferences, enhancement)

Product:
Firefox
Component:
Preferences
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 73
Tracking Flags:
Tracking Status
firefox73 --- verified

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

Details

Attachments

(3 files)

Before
41.69 KB, image/png
Details
After
43.27 KB, image/png
Details
Bug 1601345 - Replace the "<< Go Back" text link in about:preferences#containers with a button r?gijs
47 bytes, text/x-phabricator-request
Details | Review
Attached image Before —

See before vs. after.

Attached image After —

I'm guessing this will need UX approval first?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Itiel from comment #3)

I'm guessing this will need UX approval first?

I think a rubberstamp would be a good idea. Markus? This makes sense to me, but... :-)

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mjaritz)

(In reply to :Gijs (he/him) from comment #4)

(In reply to Itiel from comment #3)

I'm guessing this will need UX approval first?

I think a rubberstamp would be a good idea. Markus? This makes sense to me, but... :-)

Note that this basically aligns the "go back" interaction in the container prefs with the type of button we have in the hamburger panel for subviews, as well as in about:addons if you click through to the details pane of individual themes or add-ons.

Thanks for finding this. I agree with Gijs, it makes sense to align.

Flags: needinfo?(mjaritz)
Attachment #9113528 - Attachment description: Bug 1601345 - Replace the "<< Go Back" text link in about:preferences#containers to a button r?gijs → Bug 1601345 - Replace the "<< Go Back" text link in about:preferences#containers with a button r?gijs
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/378a907c4c3f
Replace the "<< Go Back" text link in about:preferences#containers with a button r=Gijs,fluent-reviewers

https://hg.mozilla.org/mozilla-central/rev/378a907c4c3f

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
Status: RESOLVED → VERIFIED
status-firefox73: fixed → verified
You need to log in before you can comment on or make changes to this bug.