Closed
Bug 1601379
Opened 4 years ago
Closed 4 years ago
Extend MediaControlKeysEventSource API for initialization and deconstruction
Categories
(Core :: Audio/Video: Playback, task, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(2 files)
Because the initialization of MediaControlKeysEventSource might fail, it's no need to hold a failed source in MediaControlKeysManager.
|
||
Comment 1•4 years ago
|
||
When doing this, please also add virtual to Close().
Also, If you didn't work on it yet and you tell me how you'd want Init and Close to be named (I suggest Open and Close), I could also do this real quick :)
Flags: needinfo?(alwu)
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(alwu)
Summary: Add `Init()` function for MediaControlKeysEventSource → Extend MediaControlKeysEventSource API for initialization
|
|
Assignee | |
Comment 2•4 years ago
|
||
Sorry for my delay, I'll start this today.
Summary: Extend MediaControlKeysEventSource API for initialization → Extend MediaControlKeysEventSource API for initialization and deconstruction
|
|
Assignee | |
Comment 3•4 years ago
|
||
Add an ability for inherited sources to implement their own deconstruction operations.
|
|
Assignee | |
Comment 4•4 years ago
|
||
Add Open() to support inherited sources to implement their own initialization and also don't hold the reference of the source if it fails to initialize.
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b04d71a5277a part1 : allow inherited class to override 'Close()' r=MeFisto94 https://hg.mozilla.org/integration/autoland/rev/e0a231bcef73 part2 : add 'Open()' to know if the source initialization succeeds or not. r=MeFisto94
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b04d71a5277a
https://hg.mozilla.org/mozilla-central/rev/e0a231bcef73
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•