1601531 - Tag image descriptors with PREFER_COMPOSITOR_SURFACE where appropriate

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Glenn Watson [:gw]]

Although PREFER_COMPOSITOR_SURFACE is not currently used in WR, it would be good to do the Gecko-side work to annotate images with this field, as appropriate.

A good initial target would be to ensure all video images are tagged with this flag. In future, we may consider it for canvas elements too.

Comment 2

[Glenn Watson [:gw]]

Sotaro, would this be relatively easy to implement?

Comment 3

[Sotaro Ikeda [:sotaro]]

If we do not limit only to video, it is relatively simple. AsyncImagePipelineManager manages all async images(video, canvas, async plugin). TextureHost::ResourceUpdates() call in AsyncImagePipelineManager::UpdateImageKeys() handle all aync external images.

• https://searchfox.org/mozilla-central/rev/efdf9bb55789ea782ae3a431bda6be74a87b041e/gfx/layers/wr/AsyncImagePipelineManager.cpp#269

If we do not want canvas, pipeline->mImageHost->GetAsyncRef() could be used to check if image is come from ImageBridge. Video and plugin images come via ImageBridge. Canva image come via WebRenderBridgeParent. In this case, We do not have a way to differentiate video and plugin images. But plugin rendering is similar to video, then it seems ok to handle plugin image similar to video image.

TextureHost::ResourceUpdates() implementation is overridden by each sub class. For example, DXGITextureHostD3D11::PushResourceUpdates(), construct wr::ImageDescriptor.

• https://searchfox.org/mozilla-central/rev/efdf9bb55789ea782ae3a431bda6be74a87b041e/gfx/layers/d3d11/TextureD3D11.cpp#1032

And it seems that we need to update WrImageDescriptor.

• https://searchfox.org/mozilla-central/rev/efdf9bb55789ea782ae3a431bda6be74a87b041e/gfx/webrender_bindings/src/bindings.rs#349

Comment 4

[Glenn Watson [:gw]]

If it's simpler to just apply the tag to all of these types (image, canvas, plugin etc) that should be fine too.

Comment 5

[Sotaro Ikeda [:sotaro]]

I take the bug.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1601531 - Tag image descriptors with PREFER_COMPOSITOR_SURFACE where appropriate

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93d1dab5bf48
Tag image descriptors with PREFER_COMPOSITOR_SURFACE where appropriate r=gw

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/93d1dab5bf48