1601585 - Intermittent editor/libeditor/tests/test_bug622371.html | The start offset of the selection shouldn't change - got +0, expected 1

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=279745152&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VGOqccGLSyKvqiZMZw8kpg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-12-05T09:55:09.024Z] 09:55:09 INFO - TEST-START | editor/libeditor/tests/test_bug622371.html
[task 2019-12-05T09:55:09.025Z] 09:55:09 INFO - GECKO(3148) | [Child 3150, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 5041
[task 2019-12-05T09:55:09.063Z] 09:55:09 INFO - GECKO(3148) | [Parent 3148, Main Thread] WARNING: we only accept nsIURI interface type, patch welcome: file /builds/worker/workspace/build/src/dom/ipc/PropertyBagUtils.cpp, line 112
[task 2019-12-05T09:55:09.228Z] 09:55:09 INFO - TEST-INFO | started process screencapture
[task 2019-12-05T09:55:09.364Z] 09:55:09 INFO - TEST-INFO | screencapture: exit 0
[task 2019-12-05T09:55:09.364Z] 09:55:09 INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_bug622371.html | The start offset of the selection shouldn't change - got +0, expected 1
[task 2019-12-05T09:55:09.364Z] 09:55:09 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:322:16
[task 2019-12-05T09:55:09.364Z] 09:55:09 INFO - @editor/libeditor/tests/test_bug622371.html:32:5
[task 2019-12-05T09:55:09.364Z] 09:55:09 INFO - rval@SimpleTest/SimpleTest.js:146:30
[task 2019-12-05T09:55:09.364Z] 09:55:09 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-12-05T09:55:09.364Z] 09:55:09 INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_bug622371.html | The end offset of the selection shouldn't change - got +0, expected 1
[task 2019-12-05T09:55:09.365Z] 09:55:09 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:322:16
[task 2019-12-05T09:55:09.365Z] 09:55:09 INFO - @editor/libeditor/tests/test_bug622371.html:33:5
[task 2019-12-05T09:55:09.365Z] 09:55:09 INFO - rval@SimpleTest/SimpleTest.js:146:30
[task 2019-12-05T09:55:09.365Z] 09:55:09 INFO - GECKO(3148) | MEMORY STAT | vsize 7396MB | residentFast 219MB | heapAllocated 67MB
[task 2019-12-05T09:55:09.365Z] 09:55:09 INFO - TEST-OK | editor/libeditor/tests/test_bug622371.html | took 229ms
[task 2019-12-05T09:55:09.365Z] 09:55:09 INFO - GECKO(3148) | [Parent 3148, Main Thread] WARNING: we only accept nsIURI interface type, patch welcome: file /builds/worker/workspace/build/src/dom/ipc/PropertyBagUtils.cpp, line 112

Comment 1

[Intermittent Failures Robot]

8 failures in 5144 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6
• mozilla-central: 2

Platform breakdown:

• macosx1014-64: 3
• linux64-qr: 2
• android-em-7-0-x86_64: 1
• linux64-shippable-qr: 1
• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2019-12-02&endday=2019-12-08&tree=all

Comment 2

[Intermittent Failures Robot]

29 failures in 4867 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

This is the #50 most frequent failure this week.

Repository breakdown:

• autoland: 20
• mozilla-central: 5
• try: 4

Platform breakdown:

• linux64-qr: 8
• linux64: 5
• android-em-7-0-x86_64: 14
• macosx1014-64: 1
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2019-12-09&endday=2019-12-15&tree=all

Comment 3

[Intermittent Failures Robot]

15 failures in 951 pushes (0.016 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 14
• autoland: 1

Platform breakdown:

• linux64: 3
• macosx1014-64: 4
• linux64-qr: 1
• windows7-32: 1
• windows10-64: 3
• windows10-64-qr: 1
• linux64-shippable: 1
• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2019-12-17&endday=2019-12-17&tree=all

Comment 4

[Intermittent Failures Robot]

32 failures in 4582 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 14
• try: 16
• mozilla-central: 2

Platform breakdown:

• linux64: 8
• android-em-7-0-x86_64: 7
• linux64-qr: 6
• macosx1014-64: 5
• windows7-32: 1
• windows10-64: 3
• windows10-64-qr: 1
• linux64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2019-12-16&endday=2019-12-22&tree=all

Comment 5

[Intermittent Failures Robot]

15 failures in 1365 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 7
• autoland: 8

Platform breakdown:

• macosx1014-64-shippable: 1
• linux64-qr: 5
• linux64-shippable-qr: 2
• linux64: 5
• windows10-64-qr: 1
• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2019-12-23&endday=2019-12-29&tree=all

Comment 6

[Intermittent Failures Robot]

21 failures in 1862 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #40 most frequent failure this week.

Repository breakdown:

• mozilla-central: 6
• try: 5
• autoland: 10

Platform breakdown:

• linux64: 8
• macosx1014-64: 1
• linux64-qr: 7
• linux64-shippable-qr: 2
• windows10-64: 1
• android-em-7-0-x86_64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2019-12-30&endday=2020-01-05&tree=all

Comment 7

[Intermittent Failures Robot]

29 failures in 4472 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

This is the #47 most frequent failure this week.

Repository breakdown:

• mozilla-central: 4
• autoland: 23
• mozilla-beta: 1
• try: 1

Platform breakdown:

• linux64-shippable-qr: 2
• linux64-qr: 9
• linux64: 2
• android-em-7-0-x86_64: 12
• macosx1014-64: 3
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-01-06&endday=2020-01-12&tree=all

Comment 8

[Intermittent Failures Robot]

20 failures in 3773 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 17
• try: 3

Platform breakdown:

• android-em-7-0-x86_64: 7
• linux64-qr: 4
• linux64-shippable-qr: 1
• macosx1014-64: 1
• windows10-64: 1
• linux1804-64-qr: 3
• linux64: 1
• windows10-64-qr: 1
• linux1804-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-01-13&endday=2020-01-19&tree=all

Comment 9

[Intermittent Failures Robot]

22 failures in 4004 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3
• autoland: 14
• try: 3
• mozilla-beta: 2

Platform breakdown:

• linux1804-64-qr: 4
• macosx1014-64: 4
• android-em-7-0-x86_64: 8
• linux1804-64-shippable: 2
• windows10-64-shippable: 1
• linux1804-64: 2
• linux1804-64-asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-01-20&endday=2020-01-26&tree=all

Comment 10

[Intermittent Failures Robot]

10 failures in 2190 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9
• try: 1

Platform breakdown:

• linux1804-64-qr: 2
• macosx1014-64: 5
• linux1804-64-asan: 1
• android-em-7-0-x86_64: 1
• linux1804-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-01-27&endday=2020-02-02&tree=all

Comment 11

[Intermittent Failures Robot]

24 failures in 3364 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

This is the #29 most frequent failure this week.

Repository breakdown:

• autoland: 16
• mozilla-central: 4
• mozilla-release: 1
• try: 3

Platform breakdown:

• linux1804-64-shippable: 3
• linux1804-64-qr: 3
• linux1804-64-shippable-qr: 3
• linux64: 1
• linux1804-64: 3
• android-em-7-0-x86_64: 5
• macosx1014-64: 4
• windows10-64: 1
• linux1804-64-asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-02-03&endday=2020-02-09&tree=all

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, this orange detects actual inconsistent behavior at load event.

When it's green, HTMLEditor has already been created for contenteditable. Then, Selection::Collapse() is performed and HTMLEditor::BegginingOfDocument() is not called at turning designMode on because editing state was not off. However when it's orange, there is no selection ranges because contenteditable has not been handled yet (i.e., the editing state is still off at setting designMode to on).

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1601585 - Add a WPT to test selection in a `contenteditable` element with changing `designMode` r=smaug!

We should port editor/libeditor/tests/test_bug622371.html to WPT. It was
written for compatibility issue with CKEditor 9 years ago and Gecko and
Blink behave as exactly same. Only Safari normalize the selection into the
end of the text node, but Safari also does not change selection at turning
on/off designMode too. Therefore, all browser engines have implicit
agreement at least that selection shouldn't be changed at changing
designMode.

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1601585 - Make `Document::EditingStateChanged()` stop calling `HTMLEditor::BeginingOfDocument()` when there is a pending state change for `contenteditable` elements and there is a selection range r=smaug!

For backward compatibility, Document::EditingStateChanged() calls
HTMLEditor::BeginingOfDocument() to initialize selection when the document
becomes editable first time. However, it checks whether
Document::mEditingState was ``EditingState::eOffor not. This looks enough, but not so becauseDocument::MaybeEditingStateChanged()` calls it
asynchronously if `contenteditable` element appears at not safe to run script.
Therefore, this patch makes it check `Document::mContentEditableCount` value
which is modified synchronously from `Element::AfterSetAttr()` (additionally,
this makes it check whether there is at least a range in normal selection too,
though).

Depends on D62813

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/331fac3d22bc
Add a WPT to test selection in a `contenteditable` element with changing `designMode` r=smaug
https://hg.mozilla.org/integration/autoland/rev/313ca1b7d400
Make `Document::EditingStateChanged()` stop calling `HTMLEditor::BeginingOfDocument()` when there is a pending state change for `contenteditable` elements and there is a selection range r=smaug

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21817 for changes under testing/web-platform/tests

Comment 17

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/21817
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/XQaGXAJwT6O_JKR7kSbQ4w)

Comment 18

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/331fac3d22bc
https://hg.mozilla.org/mozilla-central/rev/313ca1b7d400

Comment 19

[Intermittent Failures Robot]

26 failures in 4690 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

This is the #34 most frequent failure this week.

Repository breakdown:

• autoland: 19
• mozilla-central: 2
• try: 4
• mozilla-beta: 1

Platform breakdown:

• android-em-7-0-x86_64: 6
• macosx1014-64: 5
• linux1804-64-qr: 5
• linux1804-64: 4
• linux1804-64-devedition: 1
• linux1804-64-shippable: 1
• linux1804-64-asan: 2
• windows10-64: 1
• linux1804-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-02-10&endday=2020-02-16&tree=all

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta backport?

Comment 21

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 22

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 23

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #20)

Is this something we should consider for Beta backport?

I think that this should ride on the train because I guess that it must be rare web apps using designMode (legacy API) to include contenteditable (modern API than the previous one). On the other hand, if there are some regressions of this change, it must appear on Thunderbird since the BeginningOfDocument call is required mainly for it. Additionally, the symptom is not reported for existing web apps.

Comment 24

[Intermittent Failures Robot]

1 failures in 4045 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Platform breakdown:

• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-02-17&endday=2020-02-23&tree=all

Comment 25

[Intermittent Failures Robot]

1 failures in 5233 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-02-24&endday=2020-03-01&tree=all

Comment 26

[Intermittent Failures Robot]

1 failures in 5483 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux1804-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-03-02&endday=2020-03-08&tree=all

Comment 27

[Intermittent Failures Robot]

1 failures in 4773 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Platform breakdown:

• linux1804-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601585&startday=2020-03-23&endday=2020-03-29&tree=all