16016 - Votes field gives wrong value in bug lists.

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Matthew Tuck [:CodeMachine]]

It seems that the "Votes" column in bug lists is wrong, it is different from
what appears in the bug itself.

I have a query:

http://bugzilla.mozilla.org/buglist.cgi?email1=&emailtype1=substring&emailassign
ed_to1=1&emailreporter1=1&emailqa_contact1=1&emailcc1=1&email2=&emailtype2=subst
ring&emailreporter2=1&changedin=&votes=3&chfieldfrom=&chfieldto=Now&chfieldvalue
=&short_desc=&short_desc_type=substring&long_desc=&long_desc_type=substring&bug_
file_loc=&bug_file_loc_type=substring&status_whiteboard=&status_whiteboard_type=
substring&newqueryname=&form_name=query&order=votesum%2C%20bugs.priority%2C%20bu
gs.bug_severity

to return the most popular bugs.  It seems that it returns the number of votes
multiplied by the number of people in the CC field!

See in particular bug #991 : 22 votes x 4 CC people = 88 and bug #3013 : 17
votes x 5 CC people = 85.

This is bad because it is affecting which bugs appear the most important.

Comment 1

[Matthew Tuck [:CodeMachine]]

Smallest URL to test on:

http://bugzilla.mozilla.org/buglist.cgi?emailcc1=1&votes=10 (works equally well
for emailcc2).

OK, well, you don't need the "votes=10", but you probably don't want to see the
query that results from its removal.  =)

Comment 2

[Terry Weissman]

F***.  Likewise, s***, d***, and h***.

I have been thinking of doing a rewrite of the way votes are stored in the db
(well, actually just adding a cached value) to simplify the SQL.  I was going to
do this for effeciency purposes.  But I think what's going on here is that SQL
just doesn't handle sum() requests the way I want it to.  So I'll go do that
rewrite in order to fix this bug.

Stay tuned...

Comment 3

[Terry Weissman]

OK, this has been fixed in the manner described.

Comment 4

[Matthew Tuck [:CodeMachine]]

Correctamundo.

Comment 5

[Dave Miller [:justdave]]

Moving to Bugzilla product