1601612 - Move to sphinx 2.X

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Documentation, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Requires Python 3

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1601612 - Move to sphinx 2.2.2 r?ahal

Depends on D55937

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1601612 - Ride along: mach doc - bump version of some dependencies r?ahal

Depends on D55959

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1601612 - Ride along: When a sphinx error is found, dump it r?ahal

Depends on D55960

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1601612 - Ride along: move the image from 16.04 to 18.04 r?ahal

Comment 5

[Sylvestre Ledru [:Sylvestre]]

It has been an interesting experience:

• Sphinx 2.2.X requires Python 3 - https://phabricator.services.mozilla.com/D55959
• But our Docker image for the doc build provides Python 3.5.
• But sphinx-js doesn't work with Python 3.5 https://github.com/mozilla/sphinx-js/pull/126#issuecomment-562707523
• And Sphinx wasn't showing the whole back trace https://phabricator.services.mozilla.com/D56168
• So, I had to update also the docker image of linting to Ubuntu 18.04 https://phabricator.services.mozilla.com/D56219

Seems that we are good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c29990f10e4d27ad5c6652ba6efee6883c27adc&selectedJob=280042707

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/457049dcb9b4
Move to sphinx 2.2.2 r=ahal
https://hg.mozilla.org/integration/autoland/rev/22099810071a
Ride along: mach doc - bump version of some dependencies r=ahal
https://hg.mozilla.org/integration/autoland/rev/67431d96c78f
Ride along: When a sphinx error is found, dump it r=ahal
https://hg.mozilla.org/integration/autoland/rev/c5b62adb19f1
Ride along: move the image from 16.04 to 18.04 r=ahal

Comment 7

[Razvan Maries]

Backed out for Lint failure.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=281517471&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linting%2Copt%2Cpython%2Cchecks%2Csource-test-mozlint-py-compat%2Cpy%28py-compat%29&revision=c5b62adb19f15910f95aca51ef7784d48ef45ce8

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281517471&repo=autoland&lineNumber=271

Backout: https://hg.mozilla.org/integration/autoland/rev/90cf0ce6c916dc56b5b5c0577f468fc5c4e89745

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1601612 - Fix some py2/py3 lints with a newer version of Python r?marco

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ccd21664edd
Fix some py2/py3 lints with a newer version of Python r=marco
https://hg.mozilla.org/integration/autoland/rev/202213a02f22
Move to sphinx 2.2.2 r=ahal
https://hg.mozilla.org/integration/autoland/rev/481f72e85975
Ride along: mach doc - bump version of some dependencies r=ahal
https://hg.mozilla.org/integration/autoland/rev/f162c75e1164
Ride along: When a sphinx error is found, dump it r=ahal
https://hg.mozilla.org/integration/autoland/rev/6e8ba3ecacf7
Ride along: move the image from 16.04 to 18.04 r=ahal

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8ccd21664edd
https://hg.mozilla.org/mozilla-central/rev/202213a02f22
https://hg.mozilla.org/mozilla-central/rev/481f72e85975
https://hg.mozilla.org/mozilla-central/rev/f162c75e1164
https://hg.mozilla.org/mozilla-central/rev/6e8ba3ecacf7

Comment 11

[Sylvestre Ledru [:Sylvestre]]

It landed for real!