1601714 - Capitalize 'p' in "Recommended by Pocket"

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Tawanda Kanhema]

Attachment: Recommended by Pocket.png

Capitalize 'p' in Recommended by Pocket.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1601714 - Capitalize 'p' in "Recommended by Pocket"

Comment 2

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: It's a super small low risk patch to fix a small regression in beta and nightly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de1f41935d79
Capitalize 'p' in "Recommended by Pocket" r=gvn

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/de1f41935d79

Comment 5

[Julien Cristau [:jcristau]]

Seems polishy. I can take an uplift, but I don't think this needs tracking.

Comment 6

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this that the 'p' in "Recommended by Pocket" is capitalized on Latest Firefox Nightly 73.0a1 (Build ID: 20191209215019) on Windows 10 x64, Mac 10.14.6 and Arch Linux 3.34.1.

Comment 7

[Julien Cristau [:jcristau]]

Please request uplift ASAP if you want this in 72.

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 9113877 [details]
Bug 1601714 - Capitalize 'p' in "Recommended by Pocket"

Beta/Release Uplift Approval Request

• User impact if declined: Just looks bad with incorrect capitalization (lack of) on a frequently seem page.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Load up a newtab and look for "Recommended by Pocket"

Expected: Should be "Recommended by Pocket" and not "Recommended by pocket"

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Super small change.

It's not a localization based string change even though it looks like it could be. It's just changing the variable we pass in for the "Pocket" string, not the localized string.

• String changes made/needed: none

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9113877 [details]
Bug 1601714 - Capitalize 'p' in "Recommended by Pocket"

newtab capitalization change, approved for 72.0b7

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/33a53ed5e9dd

Comment 11

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified that the 'p' in "Recommended by Pocket" is capitalized on Firefox Beta 72.0b7 (Build ID: 20191213132525) on Windows 10 x64, Mac 10.14.6 and Arch Linux 3.34.1.