Closed Bug 1601862 Opened 1 year ago Closed 1 year ago

Suppress false alarm log in RenderCompositorANGLE on Windows7

Categories

(Core :: Graphics: WebRender, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

Details

Attachments

(1 file)

When WebRender was enabled on Windows 7, about:support always had the following error log. But it is a false alarm.

  • Compositor window was not created
Assignee: nobody → sotaro.ikeda.g

Backed out for bustage on RenderCompositorANGLE.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/9405bc98d5e1ae63780438700d6f5bd4e5a71ab9

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=519be451c2833e9386186426426b222949e5ad5d&group_state=expanded&selectedJob=280205464

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280205464&repo=autoland&lineNumber=63402

[task 2019-12-09T01:38:13.094Z] 01:38:13 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/webrender_bindings'
[task 2019-12-09T01:38:13.094Z] 01:38:13 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/i686-w64-mingw32-clang++ -std=gnu++17 -o RenderCompositorANGLE.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -DNDEBUG=1 -DTRIMMED=1 -DMOZ_ENABLE_D3D10_LAYER -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DSTATIC_EXPORTABLE_JS_API -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/webrender_bindings -I/builds/worker/workspace/build/src/obj-firefox/gfx/webrender_bindings -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fms-extensions -fno-exceptions -fno-strict-aliasing -Wno-incompatible-ms-struct -mstackrealign -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -MD -MP -MF .deps/RenderCompositorANGLE.o.pp /builds/worker/workspace/build/src/gfx/webrender_bindings/RenderCompositorANGLE.cpp
[task 2019-12-09T01:38:13.094Z] 01:38:13 ERROR - /builds/worker/workspace/build/src/gfx/webrender_bindings/RenderCompositorANGLE.cpp:284:9: error: use of undeclared identifier 'gfxVars'; did you mean 'gfx::gfxVars'?
[task 2019-12-09T01:38:13.094Z] 01:38:13 INFO - if (gfxVars::UseWebRenderDCompWin() ||
[task 2019-12-09T01:38:13.095Z] 01:38:13 INFO - ^~~~~~~
[task 2019-12-09T01:38:13.095Z] 01:38:13 INFO - gfx::gfxVars
[task 2019-12-09T01:38:13.095Z] 01:38:13 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/gfx/gfxVars.h:74:7: note: 'gfx::gfxVars' declared here
[task 2019-12-09T01:38:13.095Z] 01:38:13 INFO - class gfxVars final {
[task 2019-12-09T01:38:13.095Z] 01:38:13 INFO - ^
[task 2019-12-09T01:38:13.096Z] 01:38:13 ERROR - /builds/worker/workspace/build/src/gfx/webrender_bindings/RenderCompositorANGLE.cpp:285:9: error: use of undeclared identifier 'gfxVars'; did you mean 'gfx::gfxVars'?
[task 2019-12-09T01:38:13.096Z] 01:38:13 INFO - gfxVars::UseWebRenderFlipSequentialWin()) {
[task 2019-12-09T01:38:13.096Z] 01:38:13 INFO - ^~~~~~~
[task 2019-12-09T01:38:13.096Z] 01:38:13 INFO - gfx::gfxVars
[task 2019-12-09T01:38:13.097Z] 01:38:13 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/gfx/gfxVars.h:74:7: note: 'gfx::gfxVars' declared here
[task 2019-12-09T01:38:13.097Z] 01:38:13 INFO - class gfxVars final {
[task 2019-12-09T01:38:13.097Z] 01:38:13 INFO - ^
[task 2019-12-09T01:38:13.097Z] 01:38:13 INFO - 2 errors generated.
[task 2019-12-09T01:38:13.097Z] 01:38:13 INFO - /builds/worker/workspace/build/src/config/rules.mk:804: recipe for target 'RenderCompositorANGLE.o' failed
[task 2019-12-09T01:38:13.097Z] 01:38:13 ERROR - make[4]: *** [RenderCompositorANGLE.o] Error 1
[task 2019-12-09T01:38:13.097Z] 01:38:13 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/webrender_bindings'
[task 2019-12-09T01:38:13.097Z] 01:38:13 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'gfx/webrender_bindings/target-objects' failed
[task 2019-12-09T01:38:13.097Z] 01:38:13 ERROR - make[3]: *** [gfx/webrender_bindings/target-objects] Error 2
[task 2019-12-09T01:38:13.098Z] 01:38:13 INFO - make[3]: *** Waiting for unfinished jobs....

Flags: needinfo?(sotaro.ikeda.g)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.