Closed Bug 1601894 Opened 3 years ago Closed 2 years ago

Compare list.json + ABSearch with modern config and figure out if the differences need to be addressed

Categories

(Firefox :: Search, task, P2)

task
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 73
Iteration:
73.2 - Dec 16 - Jan 5
Tracking Status
firefox73 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Currently, the modern configuration is based entirely off list.json. At some stage, we should compare the differences when ABSearch has been applied to list.json, and check if there's anything we should address before we ship the modern config.

For example, with the modern config eBay is currently available to most en-US locales, however, ABSearch turns it off for RO and others.

Assignee: nobody → standard8
Depends on: 1604929

Some more notes here:

  • I downloaded the ABSearch data from the live server for each locale/region combination that FF currently supports.
  • I then did a xpcshell-test that used some of the current searchconfig test functions to load and reload the engines for different locale/regions using the engine selector.
  • This then compared the identifiers of the engines with the list from ABSearch.
  • Generally, most things matched:
    • be locale has some differences, due to ABSearch having to support older engines which we don't now.
    • uk locale has some differences, but matches the current list.json which is the best thing to do.
    • zh-TW has the extra readmoo extension.
    • en-US has some differences in the shipped eBay domain (.com instead of the region specific one) - especially on some of the overrides. The patch here fixes those.

Generally though, we're good with matching, so once these have landed, we should be good now.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3b42c0737c7
Ensure the search engine configuration tests check the details for each locale/region pair, and fix eBay setup in the modern configuration. r=mikedeboer
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
Iteration: --- → 73.2 - Dec 16 - Jan 5
You need to log in before you can comment on or make changes to this bug.