Closed Bug 1601949 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20652 - [WebNFC] Disallow id for an empty NDEF record

Categories

(Core :: DOM: Device Interfaces, task, P4)

Product:
Core
Component:
DOM: Device Interfaces
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20652 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20652
Details from upstream follow.

Francois Beaufort <beaufort.francois@gmail.com> wrote:

[WebNFC] Disallow id for an empty NDEF record

As stated in https://w3c.github.io/web-nfc/#empty-ndef-record-tnf-0, an
empty record's' TYPE LENGTH field, ID LENGTH field and PAYLOAD LENGTH
field MUST be 0, thus the TYPE field, ID field and PAYLOAD field MUST
NOT be present.

Spec change: https://github.com/w3c/web-nfc/pull/460

Bug=520391

Change-Id: Ia74d80d5ddd5031ad4fc921a6951572365f89565
Reviewed-on: https://chromium-review.googlesource.com/1954479
WPT-Export-Revision: 30a64f0774c4ff6381481c206119df31768fc942

PR 20652 applied with additional changes from upstream: d9ee4f3e4ef4792b085687584981611e0b74f003
Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Test result changes from PR not available.
Test result changes from PR not available.

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 18 subtests

Status Summary

Firefox

OK : 1
FAIL: 18

Chrome

OK : 1
PASS: 5
FAIL: 13

Safari

OK : 1
FAIL: 18

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-nfc/NDEFRecord_constructor.https.html
NDEFRecord constructor with absolute-url record type: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type and arrayBuffer data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with empty record type and id: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor should only accept mediaType for mime record type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord constructor with external record type: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with custom record ids: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with url record type: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor without init dict: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord constructor with record type string being treated as case sensitive: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord constructor with mime record type and json data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with invalid external record type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord constructor with mime record type and stream data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type and custom document language: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with unknown record type: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type and string data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type, encoding, and lang: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with text record type and arrayBufferView data: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord constructor with null init dict: FAIL (Chrome: PASS, Safari: FAIL)

https://hg.mozilla.org/mozilla-central/rev/6ec99807e8d8
https://hg.mozilla.org/mozilla-central/rev/794b963e6ff4

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.