1602113 - mailnews/extensions/smime/src/nsCertPicker.cpp:232:7: error: use of undeclared identifier 'do_CreateInstance'

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:aceman]

The compilation fails in current trunk of Thunderbird with this error:
mailnews/extensions/smime/src/nsCertPicker.cpp:232:7: error: use of undeclared identifier 'do_CreateInstance'

Comment 1

[:aceman]

Attachment: 1602113.patch

Looks like some includes have changed in m-c and now we are not inheriting the nsComponentManagerUtils.h as before in some c-c files.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e7f9cbc2f6d5781e5d7fff7743500bccc55f44a9

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f44ace76831e
add some missing includes of nsComponentManagerUtils.h. r=rjl

Comment 3

[Jorg K (CEST = GMT+2)]

This was caused by bug 1600545. Sadly it left TB busted due to unified compilation issues in M-C code:

 0:17.29 In file included from Unified_cpp_parser_html0.cpp:2:
 0:17.29 In file included from c:/mozilla-source/comm-central/parser/html/nsHtml5AtomTable.cpp:5:
 0:17.29 In file included from c:/mozilla-source/comm-central/parser/html/nsHtml5AtomTable.h:8:
 0:17.29 In file included from c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/include/nsHashKeys.h:12:
 0:17.29 In file included from c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/include\nsAutoPtr.h:10:
 0:17.29 c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/include\nsCOMPtr.h(414,5): error: no matching function for call to 'ToSupports'
 0:17.29     NSCAP_LOG_ASSIGNMENT(this, aNewPtr);
 0:17.29     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

So clearly bug 1519936 wasn't fixed :-(

Comment 4

[Jorg K (CEST = GMT+2)]

According to https://hg.mozilla.org/try-comm-central/rev/ed6f5f34c520d586059e7ed1080a53f036a5a867#l2.2, there is still one missing.

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1602113-saxparser.patch

SeaMonkey needs another fix.

Comment 6

[Frank-Rainer Grahl (:frg)]

Oh I see Jorg already found it too. Can someone check it in.

Comment 7

[Magnus Melin [:mkmelin]]

Let's wait for the follow-up to bug 1600545 to be merged to mozilla-central. Then we're building again.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9d375b52da67
Add missing include of nsComponentManagerUtils.h to saxparser. r=frg

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/49bc32a100a3
Follow-up: Reformat. rs=reformat DONTBUILD