1602163 - VideoPlaybackQuality corruptedFrames deprecated

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Chris Cunningham]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36

Steps to reproduce:

VideoPlaybackQuality initially shipped with a corruptedFrames attribute. Media WG resolved to remove it from the spec.

https://github.com/w3c/media-playback-quality/pull/20

This issue tracks updates to Firefox to remove it from the API.

Note: While most implementers simply returned 0, some sites out there may still be expecting this attribute to exist (ex: if only to log it). We are just now shipping the VideoPlaybackQuality API in Chrome, so we don't have telemetry on usage of corruptedFrames. Our plan is to collect some metrics and potentially deprecate this slowly.

Chrome ship thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fgE0Ua9ZSU8/3XM9bU1LAgAJ

Comment 1

[Jean-Yves Avenard [:jya]]

Alistair, is this something you could take over?

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1602163 - part2 : remove 'corruptedFrames' from 'VideoPlaybackQuality'

According to [1], we're going to deprecate this attribute.

[1] https://github.com/w3c/media-playback-quality/pull/20

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1602163 - part1 : remove usage of 'corruptedVideoFrames' in tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c086b8b46df
part1 : remove usage of 'corruptedVideoFrames' in tests. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/a2bf666e1742
part2 : remove 'corruptedFrames' from 'VideoPlaybackQuality' r=bzbarsky

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20714 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/20714
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/LAdGtWnHTSKoPAoVQd2p8g)

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8c086b8b46df
https://hg.mozilla.org/mozilla-central/rev/a2bf666e1742

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham

Comment 9

[Kohei Yoshino [:kohei]]

Posted site compatibility note.

Comment 10

[Eric Shepherd [:sheppy]]

Documentation updated:

• Updated the corruptedVideoFrames page a bit
• Submitted PR 5489
• Added an entry to Firefox 73 for developers