1602358 - Fails to build with cbindgen 0.11.1

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jan Beich]

In file included from Unified_cpp_xpcom_components0.cpp:38:
In file included from firefox-71.0/xpcom/components/nsComponentManager.cpp:36:
In file included from objdir/dist/include/nsThreadManager.h:12:
In file included from objdir/dist/include/nsThread.h:27:
In file included from objdir/dist/include/mozilla/dom/DocGroup.h:17:
In file included from objdir/dist/include/mozilla/dom/CustomElementRegistry.h:13:
In file included from objdir/dist/include/mozilla/CycleCollectedJSContext.h:17:
In file included from objdir/dist/include/mozilla/dom/AtomList.h:11:
In file included from objdir/dist/include/mozilla/dom/GeneratedAtomList.h:6:
In file included from objdir/dist/include/mozilla/dom/BindingUtils.h:36:
In file included from objdir/dist/include/mozilla/dom/Document.h:47:
In file included from objdir/dist/include/mozilla/StaticPresData.h:13:
In file included from objdir/dist/include/nsFont.h:12:
In file included from objdir/dist/include/gfxFontFamilyList.h:13:
In file included from objdir/dist/include/nsStyleConsts.h:17:
objdir/dist/include/mozilla/ServoStyleConsts.h:10840:20: error: class member cannot be redeclared
  StyleWritingMode operator^(const StyleWritingMode& other) const {
                   ^
objdir/dist/include/mozilla/ServoStyleConsts.h:10827:20: note: previous definition is here
  StyleWritingMode operator^(const StyleWritingMode& other) const {
                   ^
objdir/dist/include/mozilla/ServoStyleConsts.h:10843:21: error: class member cannot be redeclared
  StyleWritingMode& operator^=(const StyleWritingMode& other) {
                    ^
objdir/dist/include/mozilla/ServoStyleConsts.h:10830:21: note: previous definition is here
  StyleWritingMode& operator^=(const StyleWritingMode& other) {
                    ^
2 errors generated.

Full error log: https://reviews.freebsd.org/P339

Comment 1

[Emilio Cobos Álvarez (:emilio)]

This is expected. I'm updating it in bug 1602317. Just dealing with some windows build shenanigans.

Comment 2

[Jan Beich]

Do you plan to backport the fix to Firefox 71 and 72? If not it'd require downstream to have more than one cbindgen package.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Hmm, I could try to fix it so it'd build with newer cbindgen too.

The fix is really just removing this section (as cbindgen would generate them automatically). But I'll try to make builds work regardless of which cbindgen version is used, shouldn't be hard.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1602358 - Fix older builds with newer cbindgen. r=heycam

This should be fine to uplift so that downstream doesn't need multiple cbindgen
versions.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9114522 [details]
Bug 1602358 - Fix older builds with newer cbindgen. r=heycam

Beta/Release Uplift Approval Request

• User impact if declined: none
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor build fix so that beta builds with newer cbindgen versions.
• String changes made/needed: none

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9114522 [details]
Bug 1602358 - Fix older builds with newer cbindgen. r=heycam

build fix for newer cbindgen, approved for 72.0b5

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b7a8631178f

Comment 8

[Landry Breuil (:gaston)]

I'm a bit puzzled since i had no issues building m-c or 72.0b4 with cbindgen 0.11.1 on OpenBSD.. but still, good thing that it is fixed.

Comment 10

[Landry Breuil (:gaston)]

(In reply to Landry Breuil (:gaston) from comment #8)

I'm a bit puzzled since i had no issues building m-c or 72.0b4 with cbindgen 0.11.1 on OpenBSD.. but still, good thing that it is fixed.

Doh, stupid me - had no issues with cbindgen 0.11.0 but indeed fails with 0.11.1. Now backporting this..