1602382 - Disable Base Profiler on Windows until bug 1599015 (Crash in WindowsDllDetourPatcher<T>::CreateTrampoline) is fixed

Status: RESOLVED WORKSFORME

(Core :: Gecko Profiler, task, P1)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

See bug 1599015 for details of the crash.

In the meantime, I'm going to disable Base Profiler on Windows.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1602382 - Temporarily disable Base Profiler on Windows - r?canaltinova

As per bug 1599015 there are crashes in
mozilla::interceptor::WindowsDllDetourPatcher<T>::CreateTrampoline
which are linked to the Base Profiler's dll-load hooks.

While the issue is being investigated, Base Profiler should be disabled on
Windows to avoid more crashes.

Technical detail: The never-defined macro
DISABLE_WINDOWS_BASE_PROFILER_UNTIL_BUG_1599015_IS_FIXED is effectively always
falsy, which leaves MOZ_BASE_PROFILER undefined on Windows.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:gerald, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

We don't need this anymore, see bug 1599015 comment 17.