Closed Bug 1602418 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 20678 - [css-pseudo] Fix position of outside 'content' markers

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20678 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20678
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-pseudo] Fix position of outside 'content' markers

The position of an outside marker is calculated depending on the
'list-style-type' property. However, this patch ensures that if ::marker
has a non-normal 'content', the end of the marker will be aligned with
the start of the list item, regardless of 'list-style-type'.

The patch also simplifies the logic in InlineMarginsForOutside, since
the code for LTR and RTL directions was basically the same.

Spec: https://drafts.csswg.org/css-lists/#content-property

BUG=457718

TEST=web_tests/external/wpt/css/css-pseudo/marker-content-012.html

The test fails in legacy because 'content' doesn't work in ::marker yet.

Change-Id: I21cfd4ad3e21f2e19e8639809270bf3b4c1ad5dd
Reviewed-on: https://chromium-review.googlesource.com/1953625
WPT-Export-Revision: 9fc40db94b9b2548087fe4ba76e8bd21eac535f1

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/marker-content-012.html: FAIL [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/marker-content-012.html: FAIL [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/marker-content-012.html: FAIL [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f48677e9638
[wpt PR 20678] - [css-pseudo] Fix position of outside 'content' markers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c9682287361d
[wpt PR 20678] - Update wpt metadata, a=testonly

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/marker-content-012.html: FAIL [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: FAIL, Safari: FAIL)

Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.