1602423 - Remove xpidl [array] use in calIRecurrenceInfo.idl

Status: RESOLVED FIXED

(Calendar :: General, task)

Comment 1

[Ben Campbell]

Attachment: 1602423-xpidl-array-removal-in-calIRecurrenceInfo-1.patch

Try run covering all the calendar recurrence patches:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a8b670ba0bb1717ad6a4bc8ca55b0305df4bcd84

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9117502 [details] [diff] [review]
1602423-xpidl-array-removal-in-calIRecurrenceInfo-1.patch

Review of attachment 9117502 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like you missed some occurrence. Didn't look into what but at least the tests aren't happy. Like

TEST-UNEXPECTED-FAIL | comm/calendar/test/browser/recurrence/browser_lastDayOfMonth.js | uncaught exception - NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [calIRecurrenceRule.getOccurrences] at calculateDates@resource://calendar/calendar-js/calRecurrenceInfo.js:479:29 

Since this is calendar, I'd let Geoff review

Comment 3

[Ben Campbell]

The problem was in the calIRecurranceItem changes in Bug 1602424, addressed over there in a new patch.
No changes needed here.

Again, covered by this try build:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5cb6d13351199bb8ebbf8a7c2befc2d5c997a16a

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9117502 [details] [diff] [review]
1602423-xpidl-array-removal-in-calIRecurrenceInfo-1.patch

LGTM

Comment 5

[Magnus Melin [:mkmelin]]

Please rebase

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0bcd93317f9
Remove xpidl [array] use in calIRecurrenceInfo. r=darktrojan

Comment 7

[Jorg K (CEST = GMT+2)]

Would you mind putting the DONTBUILD into the commit message line. Like this, it's clearly visible without having to open the changeset.

Comment 8

[Magnus Melin [:mkmelin]]

Why do you want to see it?

Comment 9

[Jorg K (CEST = GMT+2)]

So I don't have have to scratch my head wondering why certain jobs didn't run. I'm not sure why you are lobbying "Magnus-only" rules here when the rest of the project and all of Mozilla put it onto the first line.

Comment 10

[Magnus Melin [:mkmelin]]

I'm not lobbying any rules, and am unaware of any rules in this regard. I just had a good reason to put it there in this bug: the job should run, just that the nightly cron job was going to take care of it anyway minutes later.

Comment 11

[Jorg K (CEST = GMT+2)]

Sure, if we land stuff just before the Daily run, we typically land with DONTBUILD if it's a small change. But the DONTBUILD goes onto the same line as the commit message. That's how we've always done it and that's how Mozilla do it. On the tree you can hover the shortened line and it will show it to you completely in the tooltip.