Closed
Bug 1602429
Opened 4 years ago
Closed 4 years ago
[jsdbg2] Explore ways to to simplify the boilerplate around resumption value handling
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: loganfsmyth, Assigned: loganfsmyth)
References
(Blocks 1 open bug)
Details
Attachments
(6 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
The logic managing how hooks process ResumeMode and implement the given behavior is repeated a lot and varies kind of randomly depending on which hook you're looking at. There's a lot that can be done to simplify all of this.
|
||
Updated•4 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•4 years ago
|
||
Depends on D57727
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D57929
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D57930
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D57931
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D57932
|
|
Assignee | |
Comment 6•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9122584 -
Attachment description: Bug 1602429 - Part 1: Split up hook dispatch so we can validate debuggee state before dispatching. → Bug 1602429 - Part 1: Split up hook dispatch so we can validate debuggee state before dispatching. r=jimb!
|
|
||
Updated•4 years ago
|
Attachment #9117164 -
Attachment description: Bug 1602429 - Part 1: Merge GetThisValueForCheck into CheckResumptionValue. r=jimb! → Bug 1602429 - Part 2: Merge GetThisValueForCheck into CheckResumptionValue. r=jimb!
|
|
||
Updated•4 years ago
|
Attachment #9117165 -
Attachment description: Bug 1602429 - Part 2: Remove processParsedHandlerResult function. r=jimb! → Bug 1602429 - Part 3: Centralize leaveDebugger calls. r=jimb!
|
|
||
Updated•4 years ago
|
Attachment #9117166 -
Attachment description: Bug 1602429 - Part 3: Reimplement processHandlerResult with less ResumeMode. r=jimb! → Bug 1602429 - Part 4: Reimplement processParsedHandlerResult with less ResumeMode. r=jimb!
|
|
||
Updated•4 years ago
|
Attachment #9117167 -
Attachment description: Bug 1602429 - Part 4: Wait to wrap debugger resumption values. r=jimb! → Bug 1602429 - Part 5: Wait to wrap debugger resumption values. r=jimb!
|
|
||
Updated•4 years ago
|
Attachment #9117174 -
Attachment description: Bug 1602429 - Part 5: Centralize debugger hook error reporting. r=jimb! → Bug 1602429 - Part 6: Centralize debugger hook realm enter and error reporting. r=jimb!
Pushed by loganfsmyth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/926f8f8032c5 Part 1: Split up hook dispatch so we can validate debuggee state before dispatching. r=jimb https://hg.mozilla.org/integration/autoland/rev/38b9f8abf279 Part 2: Merge GetThisValueForCheck into CheckResumptionValue. r=jimb https://hg.mozilla.org/integration/autoland/rev/faa91e395be4 Part 3: Centralize leaveDebugger calls. r=jimb https://hg.mozilla.org/integration/autoland/rev/7a399fa14b3b Part 4: Reimplement processParsedHandlerResult with less ResumeMode. r=jimb https://hg.mozilla.org/integration/autoland/rev/ac385bfdc04d Part 5: Wait to wrap debugger resumption values. r=jimb https://hg.mozilla.org/integration/autoland/rev/a360254cd1ec Part 6: Centralize debugger hook realm enter and error reporting. r=jimb
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/926f8f8032c5
https://hg.mozilla.org/mozilla-central/rev/38b9f8abf279
https://hg.mozilla.org/mozilla-central/rev/faa91e395be4
https://hg.mozilla.org/mozilla-central/rev/7a399fa14b3b
https://hg.mozilla.org/mozilla-central/rev/ac385bfdc04d
https://hg.mozilla.org/mozilla-central/rev/a360254cd1ec
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•