Closed Bug 1602458 Opened 2 years ago Closed 2 years ago

Speed up the picture caching pre_update/post_update in frame building


(Core :: Graphics: WebRender, enhancement, P3)




Tracking Status
firefox73 --- fixed


(Reporter: nical, Assigned: nical)


(Blocks 1 open bug)



(6 files)

Profiling the test cases from bug 1512789 and bug 1527964, I see a non-trivial amount of frame building time spent in picture caching related code. In particular, TileCacheInstance pre_update and post_update stand out with a lot of hash map insertion causing reallocation and memcpys. These two add up to between 10% and 28% of total frame building time on the profiled test cases.

Summary: Speed up the picture caching code in frame building → Speed up the picture caching pre_update/post_update in frame building
Assignee: nobody → nical.bugzilla
Pushed by
Avoid reallocating opacity bindings and tiles hash maps in TileCacheInstance. r=gw
Avoid reallocaitng spatial nodes hash map. r=gw
Avoid reallocating the tile compare cache each rame. r=gw
Recycle some hash map allocations after scene swap. r=gw
Avoid unnecessary vector allocations when splitting the tile cache. r=gw
Prevent recycled hash maps from growing indefinitely. r=gw
You need to log in before you can comment on or make changes to this bug.