Closed Bug 1602458 Opened 3 months ago Closed 2 months ago

Speed up the picture caching pre_update/post_update in frame building

Categories

(Core :: Graphics: WebRender, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: nical, Assigned: nical)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Profiling the test cases from bug 1512789 and bug 1527964, I see a non-trivial amount of frame building time spent in picture caching related code. In particular, TileCacheInstance pre_update and post_update stand out with a lot of hash map insertion causing reallocation and memcpys. These two add up to between 10% and 28% of total frame building time on the profiled test cases.

Summary: Speed up the picture caching code in frame building → Speed up the picture caching pre_update/post_update in frame building
Assignee: nobody → nical.bugzilla
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f28f9e9ec25
Avoid reallocating opacity bindings and tiles hash maps in TileCacheInstance. r=gw
https://hg.mozilla.org/integration/autoland/rev/afdbc1744519
Avoid reallocaitng spatial nodes hash map. r=gw
https://hg.mozilla.org/integration/autoland/rev/116c84612571
Avoid reallocating the tile compare cache each rame. r=gw
https://hg.mozilla.org/integration/autoland/rev/59cfb8104165
Recycle some hash map allocations after scene swap. r=gw
https://hg.mozilla.org/integration/autoland/rev/1f03147b3854
Avoid unnecessary vector allocations when splitting the tile cache. r=gw
https://hg.mozilla.org/integration/autoland/rev/98758fb91218
Prevent recycled hash maps from growing indefinitely. r=gw
You need to log in before you can comment on or make changes to this bug.