1602458 - Speed up the picture caching pre_update/post_update in frame building

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Nicolas Silva [:nical]]

Profiling the test cases from bug 1512789 and bug 1527964, I see a non-trivial amount of frame building time spent in picture caching related code. In particular, TileCacheInstance pre_update and post_update stand out with a lot of hash map insertion causing reallocation and memcpys. These two add up to between 10% and 28% of total frame building time on the profiled test cases.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1602458 - Avoid reallocating opacity bindings and tiles hash maps in TileCacheInstance. r=gw

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1602458 - Avoid reallocaitng spatial nodes hash map. r=gw

Depends on D56406

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1602458 - Avoid reallocating the tile compare cache each rame. r=gw

Depends on D56407

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1602458 - Recycle some hash map allocations after scene swap. r=gw

Depends on D56408

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 1602458 - Avoid unnecessary vector allocations when splitting the tile cache. r=gw

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 1602458 - Prevent recycled hash maps from growing indefinitely. r=gw

Depends on D56426

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f28f9e9ec25
Avoid reallocating opacity bindings and tiles hash maps in TileCacheInstance. r=gw
https://hg.mozilla.org/integration/autoland/rev/afdbc1744519
Avoid reallocaitng spatial nodes hash map. r=gw
https://hg.mozilla.org/integration/autoland/rev/116c84612571
Avoid reallocating the tile compare cache each rame. r=gw
https://hg.mozilla.org/integration/autoland/rev/59cfb8104165
Recycle some hash map allocations after scene swap. r=gw
https://hg.mozilla.org/integration/autoland/rev/1f03147b3854
Avoid unnecessary vector allocations when splitting the tile cache. r=gw
https://hg.mozilla.org/integration/autoland/rev/98758fb91218
Prevent recycled hash maps from growing indefinitely. r=gw

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7f28f9e9ec25
https://hg.mozilla.org/mozilla-central/rev/afdbc1744519
https://hg.mozilla.org/mozilla-central/rev/116c84612571
https://hg.mozilla.org/mozilla-central/rev/59cfb8104165
https://hg.mozilla.org/mozilla-central/rev/1f03147b3854
https://hg.mozilla.org/mozilla-central/rev/98758fb91218