1602516 - The DOMNode key for the property in the properties panel, is now called nodeFront.

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

This is because we do not localize names of accessible properties however we not change the name DOMNode to nodeFront in the Accessible component to disambiguate variable names and this particular one must be localized.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1602516 - ensure that the key for a DOM node property in the sidebar is always DOMNode. r=mtigley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03b07a49778c
ensure that the key for a DOM node property in the sidebar is always DOMNode. r=mtigley

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/03b07a49778c

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9114649 [details]
Bug 1602516 - ensure that the key for a DOM node property in the sidebar is always DOMNode. r=mtigley

Beta/Release Uplift Approval Request

• User impact if declined: A11y Panel users will see a different label for a DOMNode property in the sidebar.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simply renaming the label regression caused by bug 1598060 (does not need to be localized).
• String changes made/needed: None

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

(In reply to Yura Zenevich [:yzen] from comment #4)

• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

Please do provide some STR?

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Julien Cristau [:jcristau] from comment #6)

(In reply to Yura Zenevich [:yzen] from comment #4)

• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

Please do provide some STR?

Sorry , accidentally answered Yes there.

Comment 8

[Bogdan Maris, Desktop QA]

(In reply to Yura Zenevich [:yzen] from comment #7)

(In reply to Julien Cristau [:jcristau] from comment #6)

(In reply to Yura Zenevich [:yzen] from comment #4)

• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

Please do provide some STR?

Sorry , accidentally answered Yes there.

Based on this I will remove qe-verify+ flag.

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9114649 [details]
Bug 1602516 - ensure that the key for a DOM node property in the sidebar is always DOMNode. r=mtigley

devtools regression fix for 72.0b7

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a3e6d37e53fa