Closed Bug 1602522 Opened 1 year ago Closed 1 year ago

Fix Icons alignment inside Triplets onboarding cards

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 73
Iteration:
73.1 - Dec 2 - Dec 15
Tracking Status
firefox72 --- verified
firefox73 --- verified

People

(Reporter: pdahiya, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

With fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1599901 we have adjusted icon sizes. Smal followup fix to adjust icon container width so that icon shows center aligned

Iteration: --- → 73.1 - Dec 2 - Dec 15
Assignee: nobody → pdahiya
Attached image Icon_before.png
Attached image Icon after width adjust
Priority: -- → P1
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/854220e52f6e
Fix triplets card icon alignment r=k88hudson
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73

Is this something which should be considered for Beta uplift or can this ride Fx73 to release?

Flags: needinfo?(pdahiya)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Is this something which should be considered for Beta uplift or can this ride Fx73 to release?

yes, this is a small user facing fix that will be nice to have in beta. Will submit uplift request. Thanks

Flags: needinfo?(pdahiya)
Flags: qe-verify?

QA Steps to verify

  1. Start firefox with new profile
  2. Open new tab
  3. Verify icons shown inside triplets card looks center aligned as shown in https://bugzilla.mozilla.org/show_bug.cgi?id=1602522#c2

I have verified this issue on Latest Firefox Nightly 73.0a1 (Build ID: 20191210212905) on Windows 10 x64, Mac 10.14.6 and Arch Linux 3.34.1. The width of the .onboardingMessageImage class now has the 230px value.

Status: RESOLVED → VERIFIED

Comment on attachment 9114653 [details]
Bug 1602522 - Fix triplets card icon alignment

Beta/Release Uplift Approval Request

  • User impact if declined: Triplet cards icon will show slightly misaligned to the content
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1602522#c8
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): One line CSS fix adjusting width of icon container
  • String changes made/needed: None
Attachment #9114653 - Flags: approval-mozilla-beta?
Flags: qe-verify? → qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9114653 [details]
Bug 1602522 - Fix triplets card icon alignment

css fix for new tab, verified in nightly, approved for 72.0b6

Attachment #9114653 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this issue on Firefox Beta 72.0b7 (Build ID: 20191213132525) and Latest Firefox Nightly 73.0a1 (Build ID: 20191211214629) on Windows 10 x64, Mac 10.14.6 and Linux Mint. The width of the .onboardingMessageImage class has the 230px value.

You need to log in before you can comment on or make changes to this bug.