1602522 - Fix Icons alignment inside Triplets onboarding cards

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

With fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1599901 we have adjusted icon sizes. Smal followup fix to adjust icon container width so that icon shows center aligned

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Icon_before.png

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Icon after width adjust

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1602522 - Fix triplets card icon alignment

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/854220e52f6e
Fix triplets card icon alignment r=k88hudson

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/854220e52f6e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something which should be considered for Beta uplift or can this ride Fx73 to release?

Comment 7

[Punam Dahiya [:pdahiya]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Is this something which should be considered for Beta uplift or can this ride Fx73 to release?

yes, this is a small user facing fix that will be nice to have in beta. Will submit uplift request. Thanks

Comment 8

[Punam Dahiya [:pdahiya]]

QA Steps to verify

1. Start firefox with new profile
2. Open new tab
3. Verify icons shown inside triplets card looks center aligned as shown in https://bugzilla.mozilla.org/show_bug.cgi?id=1602522#c2

Comment 9

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue on Latest Firefox Nightly 73.0a1 (Build ID: 20191210212905) on Windows 10 x64, Mac 10.14.6 and Arch Linux 3.34.1. The width of the .onboardingMessageImage class now has the 230px value.

Comment 10

[Punam Dahiya [:pdahiya]]

Comment on attachment 9114653 [details]
Bug 1602522 - Fix triplets card icon alignment

Beta/Release Uplift Approval Request

• User impact if declined: Triplet cards icon will show slightly misaligned to the content
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1602522#c8
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One line CSS fix adjusting width of icon container
• String changes made/needed: None

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9114653 [details]
Bug 1602522 - Fix triplets card icon alignment

css fix for new tab, verified in nightly, approved for 72.0b6

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e6d275f6d4c2

Comment 13

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue on Firefox Beta 72.0b7 (Build ID: 20191213132525) and Latest Firefox Nightly 73.0a1 (Build ID: 20191211214629) on Windows 10 x64, Mac 10.14.6 and Linux Mint. The width of the .onboardingMessageImage class has the 230px value.