Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Description

•

4 years ago

Sync web-platform-tests PR 20682 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20682
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[css-layout-api] IntrinsicSizes Implementation

This change adds support for the CSS Layout API intrinsicSizes()
callback function. The implementation closely matches that of the
layout() callback function.

Spec:
https://drafts.css-houdini.org/css-layout-api/#intrinsicsizes

Algorithm:
https://drafts.css-houdini.org/css-layout-api/#invoke-an-intrinsic-sizes-callback

The implementation also involved exposure of the
IntrinsicSizesResultOptions type.

Spec:
https://drafts.css-houdini.org/css-layout-api/#dictdef-intrinsicsizesresultoptions

Support was also added for the Child instrinsicSizes() function.

Spec:
https://drafts.css-houdini.org/css-layout-api/#dom-layoutchild-intrinsicsizes

Algorithm:
https://drafts.css-houdini.org/css-layout-api/#dom-layoutchild-intrinsicsizes

Bug: 726125
Change-Id: Ifc6064e069b4c9c5218c9d783b7d9de6a480e7ee

Reviewed-on: https://chromium-review.googlesource.com/1949536
WPT-Export-Revision: 2478a4ce46fb6940c23bba1f6e36d5e2c41ffcc1

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

4 years ago

Component: web-platform-tests → Layout

Product: Testing → Core

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

4 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=857a34389faca9d16e47e51c444cb278f0a85f77

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

4 years ago

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 28 tests

Status Summary

Firefox

PASS : 9
FAIL : 19

Chrome

PASS : 19
FAIL : 8
ERROR: 1

Safari

PASS : 9
FAIL : 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-layout-api/fallback-layout/bad-return.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/auto-block-size/absolute.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-03.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-contribution.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/auto-block-size/floats.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-01.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/invalid-min-max.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/constructor-error.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/floats.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/absolute.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/no-promise.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/error.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/content-size.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-02.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/invalid-fragment.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-replaced-percentage-02.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/unresolved-promise.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-replaced-percentage-01.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/invalid-child.https.html: FAIL (Chrome: PASS, Safari: FAIL)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

4 years ago

Depends on: 1606606

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 3

•

4 years ago

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 28 tests

Status Summary

Firefox

PASS : 9
FAIL : 19

Chrome

PASS : 19
FAIL : 8
ERROR: 1

Safari

PASS : 9
FAIL : 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-layout-api/fallback-layout/bad-return.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/auto-block-size/absolute.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-03.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-contribution.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/auto-block-size/floats.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-01.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/invalid-min-max.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/constructor-error.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/floats.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/absolute.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/no-promise.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/error.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/content-size.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-02.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/invalid-fragment.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-replaced-percentage-02.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/unresolved-promise.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-replaced-percentage-01.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/invalid-child.https.html: FAIL (Chrome: PASS, Safari: FAIL)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 4

•

4 years ago

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 28 tests

Status Summary

Firefox

PASS : 9
FAIL : 19

Chrome

PASS : 19
FAIL : 8
ERROR: 1

Safari

PASS : 9
FAIL : 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-layout-api/fallback-layout/bad-return.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/auto-block-size/absolute.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-03.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-contribution.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/auto-block-size/floats.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-01.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/invalid-min-max.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/constructor-error.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/floats.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/absolute.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/no-promise.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/error.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/content-size.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-02.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/invalid-fragment.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-replaced-percentage-02.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/unresolved-promise.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-replaced-percentage-01.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/invalid-child.https.html: FAIL (Chrome: PASS, Safari: FAIL)

Pulsebot

Comment 5

•

4 years ago

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0fecc15875a4
[wpt PR 20682] - [css-layout-api] IntrinsicSizes Implementation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2a33bd3d4697
[wpt PR 20682] - Update wpt metadata, a=testonly

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 6

•

4 years ago

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 28 tests

Status Summary

Firefox

PASS : 9
FAIL : 19

Chrome

PASS : 19
FAIL : 8
ERROR: 1

Safari

PASS : 9
FAIL : 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-layout-api/fallback-layout/bad-return.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/auto-block-size/absolute.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-03.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-contribution.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/auto-block-size/floats.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-01.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/invalid-min-max.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/constructor-error.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/floats.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/absolute.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/no-promise.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/error.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/content-size.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-size-02.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/invalid-fragment.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-replaced-percentage-02.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/fallback-layout/unresolved-promise.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/intrinsic-sizes/child-replaced-percentage-01.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/fallback-layout/invalid-child.https.html: FAIL (Chrome: PASS, Safari: FAIL)

Alexandru Michis [:malexandru]

Comment 7

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/0fecc15875a4
https://hg.mozilla.org/mozilla-central/rev/2a33bd3d4697

Status: NEW → RESOLVED

Closed: 4 years ago

status-firefox73: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla73

[wpt-sync] Sync PR 20682 - [css-layout-api] IntrinsicSizes Implementation

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass