Closed Bug 1602572 Opened 4 years ago Closed 4 years ago

Incomplete Tasks option broken in Task View

Categories

(Calendar :: Tasks, defect)

Lightning 68
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1593711

People

(Reporter: graham, Unassigned)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

After upgrade of Thunderbird to 68.2.1 (Linus Mint 19.1 repos), the Incomplete Tasks option in Tasks View no longer functions.
Open Tasks view.
Choose Completed Tasks option (or any other option) and option is applied.
Then choose Incomplete Tasks and the listing remains unchanged

Actual results:

It clearly does not function as, having chosen Completed tasks, all that is listed in the panel are all the completed task in the active calendar(s), and on changing to Incomplete Tasks, the list continues to show all the completed tasks

Expected results:

The task list should show just the incompleted tasks

Component: Untriaged → Tasks
Keywords: regression
Product: Thunderbird → Calendar
Version: 68 → unspecified

I've accidentally stumbled on clues as to why the fault is happening in my case. It seems to be a flaw in the recent implementation of managing repeating tasks within an ICS file.

It would seem the main program code written to determine and display "Incomplete tasks" faults when it finds entries with errors it cannot gracefully handle -- so instead, it does NOTHING. What makes this worse is that some of the errors in entries which cause the problem are internally introduced. The parser actually created the errors on entries that I identified as being involved (I have attached that selection of entries). In this instance, it creates this failure on more than one entry ;
X-LIC-ERROR;X-LIC-ERRORTYPE=PARAMETER-VALUE-PARSE-ERROR:Got a VALUE parame
ter with an illegal type for property: VALUE=DURATION
Which, of course is rubbish - VALUE=DURATION is perfectly okay as it appears all over the place without the parser being bothered.

Ultimately, I fixed my problem by taking ALL my repeating tasks out of my calendar and putting then in a separate ICS file - which, incidentally, if active, continued to cause selection of "Incomplete tasks" to do nothing. I then had the option of either repairing the entries directly inside the ICS file (using a text editor) or recreating all my repeated task entries from within Thunderbird Calendar. In fact, I did both and both working... but what a dreary long-drawn-out (hopefully non-repeating) task that was.

All this points to the faulty code being somewhere in-between the parser being called to pull out repeating task entries and the subsequent data being passed on for rendering.

When looking at the predefined filter definitions the filter for "open" (incomplete) is the only one that specifies props.occurrences. All other filters do not: https://searchfox.org/comm-central/source/calendar/base/src/calFilter.js#229

Maybe this is why there could be problem with repeating tasks? Unfortunately file history fails to give me useful information on who has been working on this file. Philipp, do you happen to know who is currently working on calendar code? To take a look if the filter definition is correct or not?

Flags: needinfo?(philipp)
See Also: → 1606639
Version: unspecified → Lightning 68

Further clues: With even just a few repeating tasks in a calendar, trying to apply a filter in the "Incomplete tasks" view does not work. Even if "Incomplete tasks" IS only showing incomplete tasks, the filter does nothing. With NO repeating tasks in a calendar, applying a filter in the "Incomplete tasks" view DOES work.
Obviously the problem is in the underlying code that pre-filters the "Incomplete tasks" view - something about the way it handles repeating tasks is at fault. To summarise:

  • Task tab's "Incomplete tasks" view option is completely broken by certain repeating tasks that have some feature that is in those exampled in the attached file above = RepeatTasksCauseIncompleteToFail.ics file
  • Task tab's "Incomplete tasks" view option seems to work if there are none of the above form of repeating tasks -- however, if there are any repeated tasks, then attempting to filter the task fails totally
  • "Incomplete tasks" only works as expected if there are no repeating task in the calendar.
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
See Also: 1606639
Flags: needinfo?(philipp)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: