Closed Bug 1602628 Opened 7 months ago Closed 7 months ago

Setting "Junk" keyword does not clear "NonJunk" keyword, and vice-versa

Categories

(MailNews Core :: Networking: IMAP, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 73.0

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(1 file)

In nsImapMailFolder::SetJunkScoreForMessages the Junk keyword is added to messages marked as junk. The NonJunk keyword is added to messages marked as not junk. A message should have only one of these keywords at any time, so we should clear the NotJunk keyword if a message is junk, and the Junk keyword if it isn't.

Attachment #9114753 - Flags: review?(benc)
Comment on attachment 9114753 [details] [diff] [review]
1602628-junk-not-junk-1.diff

Marvin is waiting on this bug so let's get it sorted ASAP.
Attachment #9114753 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9114753 [details] [diff] [review]
1602628-junk-not-junk-1.diff

Review of attachment 9114753 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9114753 - Flags: review?(mkmelin+mozilla)
Attachment #9114753 - Flags: review?(benc)
Attachment #9114753 - Flags: review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/b0a9be28b628
Clear the NonJunk keyword when marking messages as junk, and the Junk keyword when marking messages as not junk; r=mkmelin DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 73.0
You need to log in before you can comment on or make changes to this bug.