1602646 - Intermittent GECKO(3512) | Assertion failure: mThread, at z:/build/build/src/xpcom/threads/nsThread.cpp:837

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=280391035&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QKzw7RAoR-eMy6bdpckLSw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-12-09T23:45:33.818Z] 23:45:33 INFO - TEST-START | browser/components/extensions/test/mochitest/test_ext_all_apis.html
[task 2019-12-09T23:45:34.856Z] 23:45:34 INFO - GECKO(3512) | [Parent 3412, Main Thread] WARNING: we only accept nsIURI interface type, patch welcome: file z:/build/build/src/dom/ipc/PropertyBagUtils.cpp, line 112
[task 2019-12-09T23:45:35.331Z] 23:45:35 INFO - GECKO(3512) | [Parent 3412, Main Thread] WARNING: we only accept nsIURI interface type, patch welcome: file z:/build/build/src/dom/ipc/PropertyBagUtils.cpp, line 112
[task 2019-12-09T23:45:35.618Z] 23:45:35 INFO - GECKO(3512) | [Parent 3412, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file z:/build/build/src/widget/PuppetWidget.cpp, line 1095
[task 2019-12-09T23:45:35.653Z] 23:45:35 INFO - GECKO(3512) | [Child 4064, Main Thread] WARNING: Fallback to BasicLayerManager: file z:/build/build/src/dom/ipc/BrowserChild.cpp, line 2736
[task 2019-12-09T23:45:35.912Z] 23:45:35 INFO - GECKO(3512) | MEMORY STAT | vsize 566MB | vsizeMaxContiguous 504MB | residentFast 123MB | heapAllocated 18MB
[task 2019-12-09T23:45:35.939Z] 23:45:35 INFO - TEST-OK | browser/components/extensions/test/mochitest/test_ext_all_apis.html | took 2118ms
[task 2019-12-09T23:45:35.954Z] 23:45:35 INFO - TEST-START | Shutdown
[task 2019-12-09T23:45:35.954Z] 23:45:35 INFO - Passed: 2
[task 2019-12-09T23:45:35.954Z] 23:45:35 INFO - Failed: 0
[task 2019-12-09T23:45:35.955Z] 23:45:35 INFO - Todo: 0
[task 2019-12-09T23:45:35.955Z] 23:45:35 INFO - Mode: e10s
[task 2019-12-09T23:45:35.955Z] 23:45:35 INFO - Slowest: 2118ms - /tests/browser/components/extensions/test/mochitest/test_ext_all_apis.html
[task 2019-12-09T23:45:35.955Z] 23:45:35 INFO - SimpleTest FINISHED
[task 2019-12-09T23:45:35.955Z] 23:45:35 INFO - TEST-INFO | Ran 1 Loops
[task 2019-12-09T23:45:35.956Z] 23:45:35 INFO - SimpleTest FINISHED
[task 2019-12-09T23:45:36.132Z] 23:45:36 INFO - GECKO(3512) | [Parent 3412, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file z:/build/build/src/netwerk/cache/nsCacheService.cpp, line 855
[task 2019-12-09T23:45:36.133Z] 23:45:36 INFO - GECKO(3512) | [Parent 3412, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file z:/build/build/src/netwerk/cache/nsCacheService.cpp, line 818
[task 2019-12-09T23:45:36.133Z] 23:45:36 INFO - GECKO(3512) | [Parent 3412, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file z:/build/build/src/netwerk/cache/nsApplicationCacheService.cpp, line 158
[task 2019-12-09T23:45:36.152Z] 23:45:36 INFO - GECKO(3512) | Assertion failure: mThread, at z:/build/build/src/xpcom/threads/nsThread.cpp:837
[task 2019-12-09T23:46:04.295Z] 23:46:04 INFO - GECKO(3512) | #01: nsThread::AsyncShutdown() [xpcom/threads/nsThread.cpp:831]
[task 2019-12-09T23:46:04.295Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.296Z] 23:46:04 INFO - GECKO(3512) | #02: nsresult mozilla::detail::RunnableMethodImpl<nsIThread ,nsresult (nsIThread::)() attribute((stdcall)),1,mozilla::RunnableKind::Standard>::Run() [xpcom/threads/nsThreadUtils.h:1179]
[task 2019-12-09T23:46:04.296Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.296Z] 23:46:04 INFO - GECKO(3512) | #03: mozilla::SchedulerGroup::Runnable::Run() [xpcom/threads/SchedulerGroup.cpp:299]
[task 2019-12-09T23:46:04.296Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.296Z] 23:46:04 INFO - GECKO(3512) | #04: nsThread::ProcessNextEvent(bool,bool *) [xpcom/threads/nsThread.cpp:1257]
[task 2019-12-09T23:46:04.296Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.296Z] 23:46:04 INFO - GECKO(3512) | #05: nsThread::Shutdown() [xpcom/threads/nsThread.cpp:928]
[task 2019-12-09T23:46:04.296Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO - GECKO(3512) | #06: mozilla::image::DecodePoolImpl::Shutdown() [image/DecodePool.cpp:111]
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO - GECKO(3512) | #07: mozilla::image::DecodePool::Observe(nsISupports *,char const *,char16_t const *) [image/DecodePool.cpp:437]
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO - GECKO(3512) | #08: nsObserverList::NotifyObservers(nsISupports *,char const *,char16_t const *) [xpcom/ds/nsObserverList.cpp:65]
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO - GECKO(3512) | #09: nsObserverService::NotifyObservers(nsISupports *,char const *,char16_t const *) [xpcom/ds/nsObserverService.cpp:295]
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO - GECKO(3512) | #10: mozilla::ShutdownXPCOM(nsIServiceManager *) [xpcom/build/XPCOMInit.cpp:639]
[task 2019-12-09T23:46:04.297Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.298Z] 23:46:04 INFO - GECKO(3512) | #11: XRE_TermEmbedding() [toolkit/xre/nsEmbedFunctions.cpp:226]
[task 2019-12-09T23:46:04.298Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.298Z] 23:46:04 INFO - GECKO(3512) | #12: mozilla::ipc::ScopedXREEmbed::Stop() [ipc/glue/ScopedXREEmbed.cpp:91]
[task 2019-12-09T23:46:04.298Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.298Z] 23:46:04 INFO - GECKO(3512) | #13: XRE_InitChildProcess(int,char * * const,XREChildData const *) [toolkit/xre/nsEmbedFunctions.cpp:786]
[task 2019-12-09T23:46:04.298Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.298Z] 23:46:04 INFO - GECKO(3512) | #14: mozilla::BootstrapImpl::XRE_InitChildProcess(int,char * * const,XREChildData const *) [toolkit/xre/Bootstrap.cpp:67]
[task 2019-12-09T23:46:04.298Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.453Z] 23:46:04 INFO - GECKO(3512) | #15: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:303]
[task 2019-12-09T23:46:04.453Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.453Z] 23:46:04 INFO - GECKO(3512) | #16: wmain [toolkit/xre/nsWindowsWMain.cpp:131]
[task 2019-12-09T23:46:04.453Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.454Z] 23:46:04 INFO - GECKO(3512) | #17: static int __scrt_common_main_seh() [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:288]
[task 2019-12-09T23:46:04.454Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.454Z] 23:46:04 INFO - GECKO(3512) | #18: kernel32.dll + 0x4ef3c
[task 2019-12-09T23:46:04.454Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.455Z] 23:46:04 INFO - GECKO(3512) | #19: ntdll.dll + 0x63618
[task 2019-12-09T23:46:04.455Z] 23:46:04 INFO -
[task 2019-12-09T23:46:04.456Z] 23:46:04 INFO - GECKO(3512) | #20: ntdll.dll + 0x635eb

Comment 1

[Andreea Pavel [:apavel]]

Karl can this be from bug 1599922 ?

Comment 2

[Karl Tomlinson (:karlt)]

Yes, looks likely.

Comment 4

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09b411cd75da8159aa6f4922d031fba538b5741a

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1602646 remove checks that mThread is set before calling ShutdownInternal() r?froydnj

mShutdownRequired is already tested to avoid multiple shutdown runnables, so
callers need not test mThread, which is racy.

DecodePoolImpl, at least, can call both Shutdown() and AsyncShutdown()
on a single thread, and the later call can occur at the same time as the
thread is exiting its event loop and clearing mThread.
https://searchfox.org/mozilla-central/rev/23d4bffcad365e68d2d45776017056b76ca9a968/image/DecodePool.cpp#91

AsyncShutdown() and Shutdown() now return NS_OK when ShutdownInternal()
returns null because this would now usually happen when shutdown has already
been initiated.

Comment 6

[Intermittent Failures Robot]

65 failures in 862 pushes (0.075 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 39
• mozilla-central: 19
• try: 7

Platform breakdown:

• windows10-64-mingwclang: 7
• windows10-64-qr: 9
• windows7-32: 20
• windows10-64: 8
• windows10-64-ccov: 3
• windows7-32-mingwclang: 12
• macosx1014-64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1602646&startday=2019-12-10&endday=2019-12-10&tree=all

Comment 7

[Alex Thayer [:alexical] (she/her)]

Attachment: Remove vestigial references to cooperative scheduling r?froydnj

GetCurrentPhysicalThread and GetCurrentVirtualThread are, in practice,
identical, as the TLS override that GetCurrentVirtualThread depends on
is never actually set. This simply removes that and renames some things/
deletes some comments.

Rebased across https://hg.mozilla.org/mozilla-central/rev/3f0b4e206853
by Karl Tomlinson <[e-mail]>.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f77c4b4c73cd
Remove vestigial references to cooperative scheduling r=froydnj
https://hg.mozilla.org/integration/autoland/rev/b1e8c6f59879
remove checks that mThread is set before calling ShutdownInternal() r=froydnj

Comment 9

[Intermittent Failures Robot]

91 failures in 922 pushes (0.099 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 66
• mozilla-central: 15
• try: 10

Platform breakdown:

• windows10-64: 10
• macosx1014-64: 5
• windows7-32: 27
• windows10-64-mingwclang: 17
• windows7-32-mingwclang: 11
• linux64: 4
• windows10-64-qr: 13
• linux64-qr: 1
• macosx1014-64-qr: 1
• windows10-64-ccov: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1602646&startday=2019-12-11&endday=2019-12-11&tree=all

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f77c4b4c73cd
https://hg.mozilla.org/mozilla-central/rev/b1e8c6f59879

Comment 11

[Intermittent Failures Robot]

164 failures in 4867 pushes (0.034 failures/push) were associated with this bug in the last 7 days.

This is the #1 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 109
• mozilla-central: 34
• try: 21

Platform breakdown:

• windows7-32: 51
• windows10-64: 19
• windows10-64-qr: 25
• windows10-64-mingwclang: 24
• windows7-32-mingwclang: 23
• windows10-64-ccov: 5
• macosx1014-64: 11
• linux64: 4
• linux64-qr: 1
• macosx1014-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1602646&startday=2019-12-09&endday=2019-12-15&tree=all