Closed
Bug 1602652
Opened 4 years ago
Closed 4 years ago
Task filter group ignored when filtering
Categories
(Calendar :: Tasks, defect)
Calendar
Tasks
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 73.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
10.47 KB,
patch
|
pmorris
:
review+
|
Details | Diff | Splinter Review |
If text is entered in the filter text box, all tasks that match it are shown, regardless of the group selected on the left (current, today, next seven days, etc.). Only tasks from the selected group should be shown.
|
Assignee | |
Comment 1•4 years ago
|
||
We forget the filter group when text is entered. I've changed the code to read the value from the UI if it's not specified. I also wrote a test which covers this and (not very thoroughly) checks that the filter groups do what they should.
Attachment #9115027 -
Flags: review?(paul)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9115027 [details] [diff] [review] 1602652-filter-group-1.diff Review of attachment 9115027 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #9115027 -
Flags: review?(paul) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4e8ac4f6b597
Fix task filtering when a filter group is selected and filter string exists; r=pmorris
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•4 years ago
|
Target Milestone: --- → 73
You need to log in
before you can comment on or make changes to this bug.
Description
•