1602735 - Update SeaMonkey website for 2.53.1 Beta 1 release

Status: RESOLVED FIXED

(SeaMonkey :: Website, task)

Description

[Ian Neal]

This will require a number of patches:

• Add some basic structure
• Fine tune content
• Enable content / push release

Comment 1

[Ian Neal]

Attachment: Structure patch [Checked in: comment 3]

Comment 2

[Ian Neal]

Attachment: Enable patch

Will need correct date and correct sizes for source / l10n tarballs.

Comment 3

[Ian Neal]

Comment on attachment 9114846 [details] [diff] [review]
Structure patch [Checked in: comment 3]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/a96fdc943b3b862dad10efeb8ada7721d3d20acb

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9114846 [details] [diff] [review]
Structure patch [Checked in: comment 3]

Security is at 60.3 not 60.2 base level. Releas enotes need to cover that many more issues including the most sensitive up to current Firefox are patched.

TB release is more 56 than 60 but hard to pin it to a level so keep it at 56.

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9114847 [details] [diff] [review]
Enable patch

Looks ok. The news need to be expanded to absolutely read the release notes before upgrading. They need to cover some things like removing a master password before upograding, doing a full profile backup and make sure to upgrade the distributed extensions.

Comment 6

[RickieES aka Ricardo Palomares]

(In reply to Frank-Rainer Grahl (:frg) from comment #5)

Looks ok. The news need to be expanded to absolutely read the release notes
before upgrading. They need to cover some things like removing a master
password before upograding, doing a full profile backup and make sure to
upgrade the distributed extensions.

Are those changes due to Firefox/Gecko version shift, or are actual changes in SeaMonkey?

Also, IIUC, may we say that SM 2.53.1 is mainly on pair with Firefox 56, but with security patches from Firefox 60.3? If so, there are some new features in Firefox 56 that I don't know if they could apply to SM 2.53, like: Firefox Screenshots? Address form autofill (for en-US)? Media opened in background tabs not played?

Regarding the things to be covered and, if applicable, the above Fx changes, I'd think the proper place would be between these two sentences:

[% rnote.basename %] contains (among other changes) the following major changes relative to [% rnote.relativeto.name %]:

[% rnote.basename %] uses the same backend as Firefox and contains the relevant Firefox [% changes.fx.tm %] security fixes.

Is that OK?

Comment 7

[Frank-Rainer Grahl (:frg)]

Are those changes due to Firefox/Gecko version shift, or are actual changes in SeaMonkey?

Some because we backported later Firefox Thunderbird NSS code. Some of actual changes. depends :) The main point is that the profile will be upgraded and thre is no going back to an older version.

Firefox Screenshots? Address form autofill (for en-US)? Media opened in background tabs not played?

These are Firefox specific extensions or tabbrowser features. Do not apply. The bookmarks manager (basically now a restyled Firefox Library) and the download manager have gotten the most visible changes. Not always 100% for the better but we needed to support the later apis.

Regarding the things to be covered and, if applicable, the above Fx changes, I'd think the proper place would be between these two sentences:
I would mostly concentrate on the security changes. There are extensive changes in the backend which come with better web compatiblity, stability and more "speed" but are not easy to describe in the release notes. Lightning i.e. has been brought up to more or less 60 functionality but you won't notice.

Comment 8

[RickieES aka Ricardo Palomares]

Attachment: Updating release notes content

First draft proposal of release notes content. I've moved the warning on profile backup to the top, perhaps I've dared too much. :-)

I've confirmed the multimedia content delay on background and layout panel on DevTools. However, I've been unable to find visible changes in the Download Manager.

I hesitate whether I should ask for feedback of needinfo. Sorry if I've misunderstood it.

Comment 9

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9116022 [details] [diff] [review]
Updating release notes content

Sorry for the delay. I and IanN are busy with l10n. 

> Due to changes in the user profile, if you have set a master password you 
> have to remove it <b>before</b> upgrading to SeaMonkey 2.53.1 Beta 1.

Technical background:
We switched to the latest nss and its sqlite format. This means key3.db will be migrated into key4.db and cert8.db into cert9.db. With a master password migration will fail. Also add a paragraph telling everyone to delete the old key3.db and cert8.db afterwards. Not doing so will expose the old credentials in them without a master password in case someone gains access to the profile data. 

> Multimedia content opened in background tabs will not play until the tab is selected.
Not sure if this is true or for Firefox only.

> This is due to changes in underlying version of Gecko platform.
Technical background: Basically we could have kept the old bookmark manager. But it was completly broken in 2.53 because of recent Gecko places api changes and also had problems before because of api changes. So I took a sledgehammer and ported the Firefox Library. Fixing it would have been too much work The result has some limitations but these can hopefully be addressed later. 

Download Manager:
The old downloads api was decommissioned so we needed to switch to the jsdownloads api Firefox used since version 2x (I think26). Overall the download manager looks the same but also has some limitations not present before: no search, some options gone, time not persisted or not availabe for some downloads (mostly mail attachement and stuff from the cache like txt files) and and and. 

Please add the location of the latest cassic NoScript 5.1.9 and uBock orgin 16.4.11 versions to the notes. Add a note that classic Adblock Plus 2.91 was not tested and might cause problems (it did for me huge memory consumption and delays in browsing).
Links in the status notes wiki under 
https://wiki.mozilla.org/SeaMonkey/StatusMeetings/2019-12-15#Extensions_and_Plugins_Compatibility_Tracking

> For HTML Validator you need to check whether the Firefox version that appears on SeaMonkey's about: page is listed on the 0.9x download page. Note that only Windows is supported at this time. 

Dead and gone I think

> SeaMonkey 2.29 dropped support for the legacy JavaScript Debugger interface (JSD1). H
Remove the whole part. venkman is dead for long enough now.

Add a not that dictionaries in Web Extension format are not yet supported so please use the last non webext version. 
Add a note that lightweight themes are no longer provided on the add-ons site. TB removed them :(
Add a note that full themes might need an update because of recent ui changes.
Add a note that TLS 1.3 is the default now.
SeaMonkey for Windows will be compiled with VS2019 so please change "SeaMonkey was built using the latest VS2017 compiler" to VS2019

System Requirements, Installation and Uninstallation:
Windows XP, XP 64 and Windows Vista is no longer supported. This included the corresponding Server versions. Minimum supported version is Windows 7 SP1 and Windows Server 2008 R2. Need to change the website for this too. 

Thanks

Comment 10

[RickieES aka Ricardo Palomares]

Attachment: Updating release notes content, version 2

New version addressing most of the points in comment #9:

What's New

• Added mention to key3.db and cert8.db removal, and how to get the path of user profile through about:support
• Added note about Download Manager
• Added note about TLS 1.3 being the current version now

Extensions and themes

• Removed mention to SeaMonkey 1.x extensions
• Removed mention to HTML Validator extension
• Bumped Enigmail version to 2.0.9
• Added notes and references to Addblock Plus, uBlock and NoScript Classic
• Added mention to WebExt dictionaries not working, despite installing correctly
• Added mention to lightweight themes removed in add-ons site
• Added mention to chance for full themes requiring update

Known Issues

• Changed VS2017 to VS2019 and VS2015 to VS2017

Some other minor changes for readability purposes

Comment 11

[RickieES aka Ricardo Palomares]

(In reply to Frank-Rainer Grahl (:frg) from comment #9)

Comment on attachment 9116022 [details] [diff] [review]
Updating release notes content

Sorry for the delay. I and IanN are busy with l10n.

Don't worry. :-)

Multimedia content opened in background tabs will not play until the tab is selected.
Not sure if this is true or for Firefox only.

I have confirmed that it works in SM 2.53.1 but not in 2.49.5. To test it, go to YouTube, open a video (ideally, a music video), wait for it to start, then open in background some of the recommended videos in the right panel. You can pause the video in the active tab to check that no sound is heard until you switch to the background tab in 2.53.1, whereas in 2.49.5 both videos play at the same time.

System Requirements, Installation and Uninstallation:
Windows XP, XP 64 and Windows Vista is no longer supported. This included
the corresponding Server versions. Minimum supported version is Windows 7
SP1 and Windows Server 2008 R2. Need to change the website for this too.

I haven't done this yet, as System Requirements is a version-independent page. Perhaps we should note it in the 2.53.1 Beta 1 release notes page until it reaches GA status, then we change the System Requirements page.

Comment 12

[Ian Neal]

Comment on attachment 9117330 [details] [diff] [review]
Updating release notes content, version 2

>+++ b/src/releases/seamonkey2.53.1/index.en.html
>@@ -62,16 +72,36 @@ for new information.

>+<ul>
>+  <li>The Bookmarks Manager has switched its name to Library, and includes now
>+    also the History list. When invoking History Window, the Library will be
"...and now also includes the History list" sounds more natural.
>+    shown with the History list selected. This is due to changes in underlying
>+    version of Gecko platform.

>@@ -121,53 +151,52 @@ then install your target release (e.g. t
>+Some extensions such as Enigmail only work on certain platforms (e.g. Windows).
I know Enigmail works for 2.49.5 on Linux, I've tested that it installs okay on 2.53.1 but not had chance to test how well it works.

Comment 13

[RickieES aka Ricardo Palomares]

(In reply to Ian Neal from comment #12)

Comment on attachment 9117330 [details] [diff] [review]
Updating release notes content, version 2

+++ b/src/releases/seamonkey2.53.1/index.en.html
@@ -62,16 +72,36 @@ for new information.

+<ul>

• <li>The Bookmarks Manager has switched its name to Library, and includes now
• also the History list. When invoking History Window, the Library will be
  "...and now also includes the History list" sounds more natural.

Thanks, corrected here.

@@ -121,53 +151,52 @@ then install your target release (e.g. t
+Some extensions such as Enigmail only work on certain platforms (e.g. Windows).
I know Enigmail works for 2.49.5 on Linux, I've tested that it installs okay
on 2.53.1 but not had chance to test how well it works.

To be honest, that sentence has been there for a long time now. :-) But is has been slightly modified. In 2.48 and 2.49.4, it read this way:

"Extensions with binary components such as Lightning, Enigmail and HTML Validator only work on certain platforms (e.g. Windows)"

But in 2.49.5, the "with binary components" were removed. Perhaps we should rephrase the sentence, so it reads somewhat like:

"Extensions with binary components such as Enigmail only work for the specific platform they are released (e.g. win extension for Windows, linux64 for Linux 64 bits)"

Comment 14

[Ian Neal]

(In reply to RickieES aka Ricardo Palomares from comment #13)

(In reply to Ian Neal from comment #12)

@@ -121,53 +151,52 @@ then install your target release (e.g. t
+Some extensions such as Enigmail only work on certain platforms (e.g. Windows).
I know Enigmail works for 2.49.5 on Linux, I've tested that it installs okay
on 2.53.1 but not had chance to test how well it works.

To be honest, that sentence has been there for a long time now. :-) But is has been slightly modified. In 2.48 and 2.49.4, it read this way:

"Extensions with binary components such as Lightning, Enigmail and HTML Validator only work on certain platforms (e.g. Windows)"

But in 2.49.5, the "with binary components" were removed. Perhaps we should rephrase the sentence, so it reads somewhat like:

"Extensions with binary components such as Enigmail only work for the specific platform they are released (e.g. win extension for Windows, linux64 for Linux 64 bits)"
Yes, that makes more sense.

Comment 15

[Ian Neal]

Attachment: Use extended information for filenames [Checked in: Comment 16]

Updates code to give option for using filenames that include locale and platform.

Comment 16

[Ian Neal]

Comment on attachment 9117683 [details] [diff] [review]
Use extended information for filenames [Checked in: Comment 16]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/6e4e294282b233903be1fe740def5b6c9d37b553

Comment 17

[Ian Neal]

Attachment: Enable patch v1.1

Updated news to reference need to read the release notes, also made links relative.

Comment 18

[RickieES aka Ricardo Palomares]

Attachment: Updating release notes content, version 3 [Checked in: Comment 34]

Addressed feedback from Ian. Perhaps the patch is mature enough to ask for formal review now.

Comment 19

[Ian Neal]

Comment on attachment 9117740 [details] [diff] [review]
Updating release notes content, version 3 [Checked in: Comment 34]


>+++ b/src/releases/seamonkey2.53.1/index.en.html
>+Extensions wit binary components such as Enigmail only work for the specific
Nit: with
>+platform they are released (e.g. win extension for Windows, linux64 for Linux
>+64 bits). Besides, matching version of extensions for SeaMonkey may not be the
I think there is a word missing here. "Besides matching version of extensions for SeaMonkey, they may not be the..."

>+latest available of those versions. Therefore, they need to be adjusted for
>+each new SeaMonkey release, which also means that an old version of such an
>+add-on can break SeaMonkey if you disabled compatibility checking (which e.g.
>+happens when you install the Add-on Compatibility Reporter add-on). Please,
We have used extension up to this point, so "extension can break SeaMonkey" and "extension). Please,"
>+note the following warnings and avice regarding extensions:</p>
Nit: advice

Also need to look at enhancements and see if there is anything that needs to be added. One that springs to mind is:
Bug 1599501 - Add Favourite folders to SeaMonkey
but only as that is a recent one. We need to update the status of some of the bugs so we can up with a useful bug search.

Getting close so r=me but frg may have additional comments.

Comment 20

[Ian Neal]

Fixed macOS folder and filenames to reflect what is generated on the builder:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/b582db04e43441d29a28c3d3435f00bb29f207b1

Comment 21

[Ian Neal]

Add some holding text, to explain page:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/8e22b448d2895abeea1ca49441788269552dc527

Comment 22

[RickieES aka Ricardo Palomares]

(In reply to Ian Neal from comment #19)

Thanks for the review, typos corrected.

+platform they are released (e.g. win extension for Windows, linux64 for Linux
+64 bits). Besides, matching version of extensions for SeaMonkey may not be the
I think there is a word missing here. "Besides matching version of
extensions for SeaMonkey, they may not be the..."

Perhaps I need to change some of the words. I understand the sentence (it was already present before) as a reminder that the latest version of any specific extension may not be the appropriate to run on SeaMonkey, but an older version of the extension will be to be used instead.

So, how about something like "Besides, keep in mind that the latest version of extensions may not be the appropriate for their use with SeaMonkey"?

Also need to look at enhancements and see if there is anything that needs to
be added. One that springs to mind is:
Bug 1599501 - Add Favourite folders to SeaMonkey
but only as that is a recent one. We need to update the status of some of
the bugs so we can up with a useful bug search.

Should I wait for a complete list before providing a new version of the patch?

Comment 23

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9117740 [details] [diff] [review]
Updating release notes content, version 3 [Checked in: Comment 34]

Sorry for the lat reply. deep into release and support "hell".

> +Due to changes in the user profile, if you have set a master password, you will
> +have to remove it <b>before</b> upgrading to SeaMonkey 2.53.1 Beta 1. After a

Should be a serious data loss warning in red letters.

To remove the password go to Preferences->Privacy&Security->Master Passwords.
Choose "Change Password..." and enter you existing master password. Do not enter anything for the the new password and just press OK. Dismiss the dialog stating that your credentials are not proteced any longer. Restart SeaMonkey and make sure your logins/passwords still work without a master password. Only then upgrade.

> +    includes the History list. 
Better "browsing history"?

> +  <li>Download Manager has been migrated to a new API. Although it looks pretty
> +    much the same as before, the search option is missing and some other minor
> +    details work differently.
> +  </li>

The migration code will only migrate pending downloads. The download history for completed downloads is not migrated.

> +Extensions wit binary components such as Enigmail only work for the specific
> +platform they are released (e.g. win extension for Windows, linux64 for Linux
> +64 bits).

Binary extensions are no longer supported. Older extensions with binary components such as Enigmail only work ...

Plugins: Only Flash is still supported. Unless you absolutely need it we recommend to either disable or remove it because of security concerns. Support for Flash will be dropped in a later 2.53 release.

>AddBlock Plus 2.91

AdBlock Plus

 > <li>The latest working version of uBlock can be found
 Mention that the so called legacy release needs to be installed. At the time of the release this will be 1.6.4.12 (unless it is upgraded again soon).
 
 > +  <li>The latest working version of NoScript Classic can be found
 
Mention 5.1.9 or 5.1.x. We just need to be sure that no ones tries to install the web extension version.
 
> <li>If you are running Windows 7 or lower "

Support for prior Windows version has been dropped so the lower can be removed.

> +    SeaMonkey was built using the latest VS2019 compiler so make sure to
> +    upgrade any older VS2017 runtime.

VS2015 or VS2017 runtime. 

> releases/seamonkey2.53.1/relnote.var

Basically this is no longer strictly based on any TB or Fx release. Security fixes for Gecko are current as of 60.3 but also a lot of later ones up to current Firefox 72 have been ported. More to come. Not sure if this should be mentioned.

I would put a recommendation for upgrading to a 2.49.x release prior to upgrading to 2.53 in. Mozilla often removes some previous migrations code and there is always a possibility that migrations from older versions are not done 100%. Migration from anything older than 2.33.1 will certainly be problematic in some cases.

Comment 24

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9117685 [details] [diff] [review]
Enable patch v1.1

Looks good. Date needs to be changed but that is at it is always is.

Comment 25

[RickieES aka Ricardo Palomares]

(In reply to Frank-Rainer Grahl (:frg) from comment #23)

Comment on attachment 9117740 [details] [diff] [review]

+Due to changes in the user profile, if you have set a master password, you will
+have to remove it <b>before</b> upgrading to SeaMonkey 2.53.1 Beta 1. After a

Should be a serious data loss warning in red letters.

It actually is, in the first key-point div. Given the additional instructions related to the profile migration, I think it is better to either:

• have a key-point div specifically for the profile migration; or
• have a red letters warning at the top instructing to carefully read a new Profile migration section in the release notes, probably right after the What's New section. That new profile migration section would have all the needed instructions.

releases/seamonkey2.53.1/relnote.var

Basically this is no longer strictly based on any TB or Fx release. Security
fixes for Gecko are current as of 60.3 but also a lot of later ones up to
current Firefox 72 have been ported. More to come. Not sure if this should
be mentioned.

I just touched the Firefox base version, based on one of your comments. Honestly, I don't know how changes in relnote.var affect what users see. :-)

Comment 26

[Ian Neal]

(In reply to RickieES aka Ricardo Palomares from comment #25)

(In reply to Frank-Rainer Grahl (:frg) from comment #23)

Comment on attachment 9117740 [details] [diff] [review]

releases/seamonkey2.53.1/relnote.var

Basically this is no longer strictly based on any TB or Fx release. Security
fixes for Gecko are current as of 60.3 but also a lot of later ones up to
current Firefox 72 have been ported. More to come. Not sure if this should
be mentioned.

I just touched the Firefox base version, based on one of your comments. Honestly, I don't know how changes in relnote.var affect what users see. :-)

If you look in the index-en.html, anything that has things like [% changes.sec.tm %] get substituted with what is in relnote.var

Comment 27

[Ian Neal]

Attachment: Add pt-BR [Checked in: comment 28]

Add pt-BR to the download table

Comment 28

[Ian Neal]

Comment on attachment 9120767 [details] [diff] [review]
Add pt-BR [Checked in: comment 28]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/42fafd97ab4feed8ff89f85cf00a46943655d3a2

Comment 29

[Frank-Rainer Grahl (:frg)]

Attachment: Interdiff on top of "Updating release notes content, version 3"

I looked over the current release notes and put my proposed changes in an interdiff on top of the version 3. Please check and integrate if you think this is ok.

Comment 30

[Ian Neal]

Attachment: Use automated langpack list generation [Checked in: Comment 31]

Use functionality added in bug 1609454

Comment 31

[Ian Neal]

Comment on attachment 9121079 [details] [diff] [review]
Use automated langpack list generation [Checked in: Comment 31]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/f06d0516cd0b85f26f62b7e83c98ca8318713d93

Comment 32

[Ian Neal]

Attachment: Enable patch v1.2

Unbitrot patch, carrying forward r+

Comment 33

[Ian Neal]

Comment on attachment 9120854 [details] [diff] [review]
Interdiff on top of "Updating release notes content, version 3"

>+++ b/src/releases/seamonkey2.53.1/index.en.html

>   <li>The Bookmarks Manager has switched its name to Library, and now also
>-    includes the History list. When invoking History Window, the Library will
>-    be shown with the History list selected. This is due to changes in
>-    underlying version of Gecko platform.
>+    includes the History list. When invoking History, the Library will
>+    be shown with the History list selected. The extensive changes were needed
>+    because of Mozilla Gecko platform api changes.
API rather than api?
I don't like "changes" mentioned twice in one sentence but not sure there is a better way of phrasing it.

>-Additional security fixes up to ESR [% changes.sec.tm %] and a few enhancements have been backported.
>+Additional important security fixes up to Current Firefox 72 and a few
>+enhancements have been backported. We will continue to enhance SeaMonkey
>+security in subsequent 2.53 beta and release versions as fast as possible.
"as fast as we are able to" rather than "as fast as possible"?

>   <li>SeaMonkey now uses gtk3 on Linux. If you experience a problem because of
>-    this please file a bug and link it to
>-    <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1367257">Switch Linux builds to GTK3 with SeaMonkey 2.49</a>.
>-    Pleae try another OS theme first. Some of them are buggy and cause problems
>-    with SeaMonkey, Thunderbird and Firefox.
>+  this please file a bug and link it to
>+  <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1367257">Switch Linux
>+  builds to GTK3 with SeaMonkey 2.49</a>. Pleae try another OS theme first.
>+  Some of them are buggy and cause problems with SeaMonkey, Thunderbird and
>+  Firefox.
Nit: "Please" rather than "Pleae"

>+  <li>If you are running Windows 7 "Send to > Mail recipient" might not work.
>+    The problem was originally reported against Thunderbird 52 and is tracked in
>     <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1356902">bug 1356902</a>.
>     As a workaround install the "Microsoft Visual Studio 2015 to 2019"
>     redistributable runtime library. For x86 install the
>     <a href="https://aka.ms/vs/16/release/vc_redist.x86.exe">VS2019 x86 runtime</a>.
>     The x86 runtime can be installed on any Windows version starting with
>     Windows XP SP3.
Do we need this last sentence as we only support Windows 7 and above now?

>+  <li><strong>Data loss warning:</strong> If you use a profile with this or
>+    any later version and then try to go back to SeaMonkey 2.49 or earlier,
>+    SeaMonkey will rename your bookmarks and history file to
>+    places.sqlite.corrupt and create a new places.sqlite file, effectively
>+    resetting your browsing history. This is because the internal format
>+    changed and the upgrade process only works in one direction.
>     Additionally, running MailNews with local folders and POP3 mail filters may
>     produce summary files that are not correctly read by previous versions of
>     SeaMonkey. If you decide to go back to a previous version of SeaMonkey, you
>-    should delete the .msf files for your local folders and POP3 accounts or
>-    repair the folders using the folder properties dialog in order to avoid
>-    potential data loss.
>+    should should do it from a profile backup only.
Nit: too many shoulds!

Comment 34

[Ian Neal]

Comment on attachment 9117740 [details] [diff] [review]
Updating release notes content, version 3 [Checked in: Comment 34]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/6c3155203c774a66b09e9a077924a8937d3652fe

Thanks for all the work

Comment 35

[Frank-Rainer Grahl (:frg)]

Attachment: 1602735-2531b1-relnotes-addendum.patch [Checked in: Comment 39]

NITs fixed.
Additonanlly a few lines reformatted to fit in 80 ch.

Added new location for classic uBlock origin.
Added download history removal as discussed over irc.

Comment 36

[Frank-Rainer Grahl (:frg)]

Attachment: 1602735-4-2531b1-enable-addendum.patch

Best to merge this with the enable patch. I don't think a separate patch is needed.

Comment 37

[Ian Neal]

Comment on attachment 9121702 [details] [diff] [review]
1602735-2531b1-relnotes-addendum.patch [Checked in: Comment 39]

LGTM r=me

Comment 38

[Ian Neal]

Attachment: Enable patch v1.3 [Checked in: Comment 39]

Incorporated frg's extra changes and removed not released warning. Carrying forward r+

Comment 39

[Ian Neal]

Comment on attachment 9121702 [details] [diff] [review]
1602735-2531b1-relnotes-addendum.patch [Checked in: Comment 39]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/d80fe4717fbeaa423bd48e833f451a22029b07b4
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/450709d0b2dfaff0bd0d4518687dfd27b5753970

Comment 40

[Ian Neal]

Attachment: Fix repo and txt file links [Checked in: Comment 41]

Comment 41

[Ian Neal]

Comment on attachment 9121711 [details] [diff] [review]
Fix repo and txt file links [Checked in: Comment 41]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/970d7074b141b3a296854d40415fcb2af14e85b8

Comment 42

[Ian Neal]

Fix outdated known issue on safe browsing:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/e255abae62462e23ad79de67ca812fb368d7549c
Correct some extra bits in the release notes:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/0b463d9c66fa93b1d7b6a0b58aed15a846ea54f9

Comment 43

[Ian Neal]

Remove mention of experimental language packs:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/4ce13730bc9c498d2279dda64e20bfc5fefd4428

Comment 44

[Ian Neal]

Updated system requirements page:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/c9a1d811613ebceeed3c7712306f53bb29337889

Comment 46

[RickieES aka Ricardo Palomares]

I'm really sorry, I've been overwhelmed with remodeling a flat of my property and didn't think it was going to be so demanding in time.

IIUC, I'm no longer required to provide feedback in any patch here (I've seen I have another one for 2.53 final). Am I right?

Comment 47

[Frank-Rainer Grahl (:frg)]

I'm really sorry, I've been overwhelmed with remodeling a flat of my property and didn't think it was going to be so demanding in time.

Did go quicker than expected in the end.

IIUC, I'm no longer required to provide feedback in any patch here (I've seen I have another one for 2.53 final). Am I right?

No but if you spot something feedback is always appreciated.

FRG

Comment 48

[Ian Neal]

Pushed fix for TB version:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/f9cc9f9f466b9fc15bffe813d0022485783b9872

Comment 49

[Ian Neal]

Pushed fix for typo loose -> lose:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/3c17059d9b6b527e5c30fcb69ed1284965925a67

Comment 50

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9121711 [details] [diff] [review]
Fix repo and txt file links [Checked in: Comment 41]

lgtm

Comment 51

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9121702 [details] [diff] [review]
1602735-2531b1-relnotes-addendum.patch [Checked in: Comment 39]

Checked in and hopefully correct :)

Comment 52

[rsx11m]

Attachment: Corrected typos in release notes, more on Adblock Plus [Checked in: comment 54]

(In reply to Frank-Rainer Grahl (:frg) from comment #23)

AddBlock Plus 2.91
AdBlock Plus

This was apparently missed. Also, it's actually "Adblock Plus" compared to "AdBlock" in its original spelling, and the version number 2.9.1 rather than 2.91 (corrected).

Not exactly following the Adblock discussions, If this was the last working version of that add-on and won't work properly any more, and no other version exists to point the user to, it might be good to say so and suggest to switch.

Comment 53

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9123011 [details] [diff] [review]
Corrected typos in release notes, more on Adblock Plus [Checked in: comment 54]

> or another ad blocker.

I don't think there exists another working blocker for 2.53.x so best to leave this bit out.

Comment 54

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9123011 [details] [diff] [review]
Corrected typos in release notes, more on Adblock Plus [Checked in: comment 54]

 https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/fd426f26a4036c524f09ec31061706ff9638642d

Comment 55

[Ian Neal]

I think we're done here, any further changes can go in Bug 1610120