1602741 - Shell drainJobQueue function may not drain the job queue if FinalizationGroups queue jobs

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P1)

Description

[Jon Coppeard (:jonco)]

From bug 1587096 comment 8:

The FinalizationGroup cleanup callback may create new jobs, e.g. resolving a promise.
I would expect that if calling drainJobQueue() triggers the CleanupFinalizationGroup job, then it would drain any resulting new microtasks.

It's probably a matter of calling js::RunJobs a second time after MaybeRunFinalizationGroupCleanupTasks in RunShellJobs.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1602741 - Ensure shell drainJobQueue() function always drains the job queue r?sfink

Previously this wouldn't drain any jobs queued by FinalizationGroup callbacks.

Comment 2

[Natalia Csoregi [:nataliaCs]]

Landed: https://hg.mozilla.org/integration/autoland/rev/123bd68fc335d975aeebc4b6f3c5a31346bfad77

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/123bd68fc335