Closed
Bug 160279
Opened 22 years ago
Closed 21 years ago
checksetup.pl doesn't check permission on data/comments
Categories
(Bugzilla :: Installation & Upgrading, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: ttimo, Assigned: sjwadsw)
Details
(Whiteboard: [fixed in 2.16.3])
Attachments
(1 file, 1 obsolete file)
710 bytes,
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
After installing bugzilla-2.16, quips were not working. cgi says 'ok your quip is in', but it never actually got in. turns out this is a permission problem in data/: total 32 -rw-r--r-- 1 root www-data 0 Jul 30 04:56 comments drwxr-x--- 2 root www-data 4096 Jul 30 04:56 duplicates -rw-r--r-- 1 root www-data 0 Jul 30 04:56 mail drwxr-sr-t 2 root www-data 4096 Jul 30 04:56 mimedump-tmp drwxr-x--- 2 root www-data 4096 Jul 30 04:56 mining -rw-r--r-- 1 root www-data 0 Jul 30 04:56 nomail -rw-rw---- 1 www-data www-data 4808 Jul 30 06:07 params drwxrwx--- 3 root www-data 4096 Jul 30 04:56 template -rw-rw---- 1 www-data www-data 1731 Jul 31 04:26 versioncache drwxrwx--- 2 root www-data 4096 Jul 30 04:56 webdot www-data needs to have write permissions. this should be dealt with by checksetup.pl
Comment 1•22 years ago
|
||
True. On the trunk, quips are in the database, so data/comments is irrelevent. Do we want to fix this for 2.16.1 (assuming we have one)?
Comment 2•22 years ago
|
||
Did this happen due to something checksetup did wrong? If not, I don't think it's important enough to fix.
Reporter | ||
Comment 3•22 years ago
|
||
it makes quip non functional not that quips are an essential feature, but they won't work without proper permissions
Assignee | ||
Comment 4•21 years ago
|
||
I ran across this some time ago, and again recently on a new installation. After fixing the problem locally, I thought I'd "do the right thing" and pass along the patch. Since checksetup.pl creates the file, it should set its permissions properly as well.
Comment 5•21 years ago
|
||
dangit, where did this get lost at.
Assignee: zach → sjwadsw
Whiteboard: [wanted for 2.16.3]
Target Milestone: --- → Bugzilla 2.16
Updated•21 years ago
|
Attachment #121368 -
Flags: review+
Comment 6•21 years ago
|
||
Comment on attachment 121368 [details] [diff] [review] proposed patch for checksetup.pl err.... we're missing a quote here, that won't work.
Attachment #121368 -
Flags: review+ → review-
Assignee | ||
Comment 7•21 years ago
|
||
Oops. The quote was there before (in my working version), but I must have made a typo when I pulled from CVS and edited (so the patch file format would be right). Wouldn't you know it: first time I submit a patch and I bungle it ...
Comment 8•21 years ago
|
||
Attachment #121368 -
Attachment is obsolete: true
Updated•21 years ago
|
Attachment #121370 -
Flags: review?(justdave)
Updated•21 years ago
|
Attachment #121370 -
Flags: review?(justdave) → review+
Comment 9•21 years ago
|
||
zach: please also add this to the 2.16.3 release notes in the "other bugs" section. (and can you also check this in on the 2.16 branch only?) thanks
Flags: approval+
Comment 10•21 years ago
|
||
Fix checked in and entry added to draft relnotes (bug 202738). Thanks Steve for fixing this.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•21 years ago
|
Whiteboard: [wanted for 2.16.3] → [fixed in 2.16.3]
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•