Remove PageStyle reference from inspector client
Categories
(DevTools :: Inspector, task, P3)
Tracking
(firefox73 fixed)
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
Details
Attachments
(1 file)
Follow-up from https://phabricator.services.mozilla.com/D55945#inline-340862
The PageStyle is requested as part of InspectorFront.initialize(). The Inspector client can retrieve it directly from that front.
With the Fission changes in place, the pageStyle is referenced contextually from the inspectorFront wherever it is needed.
This bug is to remove any leftover references to the pageStyle from the inspector client.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Fission changes made it so the PageStyle is referenced contextually from the InspectorFront of the NodeFront wherever needed. Most references in the code no longer use the static reference to PageStyle from the Inspector client (which only points to the top-level document anyway).
This patch removes that reference from the Inspector client and updates any leftover bits to use the contextual PageStyle from the abandoned /new Rules view and some tests.
The Shapes Highlighter tests will be refactored separately in Bug 1603066. This patch just corrects the references without attempting to cleanup the tests themselves.
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac5b3b9c8366 Remove PageStyle references from Inspector client; r=jdescottes
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•