1602840 - Add new bitflag preference that prevents adding new sideload addons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1602840 add pref to disable adding new sideloaded addons

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1602840 add build switch for sideloading addons

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1602840 test that we don't sideload when rebuilding XPI database

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34c81b9a65b290c0b4c2f859d95c64f7e090df16

Comment 5

[Razvan Maries]

Backed out for xpcshell perma fails on test_registry.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=285670572&resultStatus=testfailed%2Cbusted%2Cexception&revision=02d52e2e7d62baf64814ed69743c7dcd9521ba94

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285670572&repo=autoland&lineNumber=5571

Backout: https://hg.mozilla.org/integration/autoland/rev/0aa06aaa9e652f10eac1a2cbaa54bb3dc54087e8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/5ad4c0f6c5db
add build switch for sideloading addons r=zombie
https://hg.mozilla.org/mozilla-central/rev/bc6122544852
add pref to disable adding new sideloaded addons r=aswan,zombie
https://hg.mozilla.org/mozilla-central/rev/faa15c6fed65
test that we don't sideload when rebuilding XPI database r=zombie,aswan

Comment 8

[Shane Caraveo (:mixedpuppy)]

Just an FYI...this hasn't landed yet due to fighting with a couple test failures on linux.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acbb75628d35
add build switch for sideloading addons r=zombie
https://hg.mozilla.org/integration/autoland/rev/7d4df29b69ba
add pref to disable adding new sideloaded addons r=aswan,zombie
https://hg.mozilla.org/integration/autoland/rev/5972260469ab
test that we don't sideload when rebuilding XPI database r=zombie,aswan

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/acbb75628d35
https://hg.mozilla.org/mozilla-central/rev/7d4df29b69ba
https://hg.mozilla.org/mozilla-central/rev/5972260469ab