1602841 - Picture-in-Picture - Pass keyboard commands from PiP window to origin window

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, enhancement)

Description

[Adam Stevenson [:adamopenweb]]

We received feedback that users would like to be able to use keyboard controls in the PIP window to control the video, for example scrubbing back and forth.

We know that implementing a full scrubber UI is going to take a lot of effort to build.

If this is relatively straight-forward to do, it would provide a decent workaround and quickly.

Comment 1

[Gabriel [:gl] (ΦωΦ)]

Attachment: Bug 1602841 - Forward keydown events from the PiP window to origin window.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

ni?ing MattN for the question I asked in https://phabricator.services.mozilla.com/D58273#1805826.

Comment 3

[Gabriel [:gl] (ΦωΦ)]

Needinfoing @Masayuki and @m_kato on the question asked in https://phabricator.services.mozilla.com/D58273#1812291

Comment 4

[Gabriel [:gl] (ΦωΦ)]

Attachment: Bug 1602841 - Implement keystroke handling for PiP window for video controls. r=mconley

This implements keystroke handling behind a pref "media.videocontrols.picture-in-picture.keyboard-controls.enabled".
This patch handles all the keystrokes for video controls, which include play, pause,
volume decrease and increase, mute, unmute, seek forward and backward for 15 seconds
or by 10% of the max video duration, seek to beginning and seek to end.
This reuses the key handler logic from https://searchfox.org/mozilla-central/rev/cfd1cc461f1efe0d66c2fdc17c024a203d5a2fd8/toolkit/content/widgets/videocontrols.js#1687-1810.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82d1507999fd
Implement keystroke handling for PiP window for video controls. r=mconley

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/82d1507999fd

Comment 7

[Pascal Chevrel:pascalc]

Could we get a release note addition please? Thanks
https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_nominate_a_bug_for_release_notes_addition.3F

Comment 8

[Gabriel [:gl] (ΦωΦ)]

Adam, can I have you craft the release note? I would be happy to review.

Comment 9

[Adam Stevenson [:adamopenweb]]

We have decided to keep this feature in Nightly for now, as we found breakage with Netflix when using keys. So we shouldn't need a release note yet.

Comment 10

[Pascal Chevrel:pascalc]

(In reply to Adam Stevenson [:adamopenweb] from comment #9)

We have decided to keep this feature in Nightly for now, as we found breakage with Netflix when using keys. So we shouldn't need a release note yet.

We need a release note for Nightly

Comment 11

[Gabriel [:gl] (ΦωΦ)]

Space - Toggle Play/Pause
Down Arrow - Volume Decrease
Up Arrow - Volume Increase
Accel + Down Arrow - Mute
Accel + Up Arrow - Unmute
Left Arrow - Seek back 15 seconds
Accel + Left Arrow - Seek back 10%
Right Arrow - Seek forward 15 seconds
Accel + Right Arrow - Seek forward 10%
Home - Seek to beginning
End - Seek to end

Accel is CtrlKey or MetaKey for macOS

Comment 12

[Alin Ilea, Desktop QA]

Hi,

I verified this on youtube and things looks good there, but on Netflix and Amazon Prime I found some issues, one of those already logged:
https://bugzilla.mozilla.org/show_bug.cgi?id=1619252
and the other one with netflix, based on comment 9 its a known issue.

I this case should I mark this as verified or we should wait until those issues are fixed?

Thanks.

Comment 13

[Gabriel [:gl] (ΦωΦ)]

Hi(In reply to Alin Ilea from comment #12)

Hi,

I verified this on youtube and things looks good there, but on Netflix and Amazon Prime I found some issues, one of those already logged:
https://bugzilla.mozilla.org/show_bug.cgi?id=1619252
and the other one with netflix, based on comment 9 its a known issue.

I this case should I mark this as verified or we should wait until those issues are fixed?

Thanks.

Yes, I think marking this as verified sounds fine since we are already aware of the issues with bugs on file.

Comment 14

[Alin Ilea, Desktop QA]

Great, thanks!

Verified - Fixed in Nightly build 74.0a1 (build id: 20200127213955) and latest Nightly build 75.0a1 (build id: 20200306094739) using Windows 10, Mac OS 10.15 and Ubuntu 18.04.

Comment 15

[lolipopplus]

Hi
could you, or maybe anyone, create a support page for this on support.mozilla.org or simply add them into https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly ?
I noticed some of them same but maybe it should be a bit more clarified.

Comment 16

[Johannes Pfrang [:johnp]]

Comment 17

[Johannes Pfrang [:johnp]]

Sorry for the noise, I misinterpreted the code and likely my DE is to blame for it not working for me m(