[wpt-sync] Sync PR 20708 - [LayoutNG] Fix hyphens when rewinding occurs
Categories
(Core :: Layout: Text and Fonts, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 20708 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/20708
Details from upstream follow.
Koji Ishii <kojii@chromium.org> wrote:
[LayoutNG] Fix hyphens when rewinding occurs
This is a re-land of:
https://chromium-review.googlesource.com/c/chromium/src/+/1868534The original patch caused a regression and was reverted for
crbug.com/1028817. A test was added for the case at:
https://chromium-review.googlesource.com/c/chromium/src/+/1941451The problem happened when |HandleOverflow| tried to break a
text item but it didn't fit. |NGLineBreaker| looks for
previous opportunities and rewind, but items it tried to
break were modified, which confused |NGLineBreaker|.The old patch stopped rewinding there. The new approach is to
restore the original item when it failed to break so that it
can always see the original items.:: The original description follows ::
This patch removes |NGLineInfo::LineEndFragment|, which was
introduced to support hyphens and ellipsis with the single
code. However, ellipsis was changed to use different code,
and |LineEndFragment| ended up with non-optimal way to handle
hyphens.Although hyphens appear at most once in a line, storing this
to |NGLineInfo| makes harder to keep it in sync with the
hyphenated item. This patch changes it to a field in
|NGInlineItemResult|.Bug: 1015297
Change-Id: I1dab0dacd8445ed563527bdc90d58b18470725f1
Reviewed-on: https://chromium-review.googlesource.com/1943784
WPT-Export-Revision: f15896834523017b7486b8dae8183d010d5597f6
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5382822c43a819766e654ee5e73ed76c2b4594bb
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
FAIL: 1
Safari
PASS: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8804236fbe7a [wpt PR 20708] - [LayoutNG] Fix hyphens when rewinding occurs, a=testonly
Comment 4•4 years ago
|
||
bugherder |
Description
•