1602890 - iframe storage under $profile/storage/default is unpartitioned when dynamic FPI is enabled

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Gary Chen [:xeonchen]]

STR:

1. set network.cookie.cookieBehavior to 5
2. navigate https://senglehardt.com/test/trackingprotection/test_pages/social_tracking_protection.html
3. open Storage Inspector
4. check directories under $profile/storage/default

Expect Result:
iframes under dummytracker.org domain should be first-party-domain partitioned.

Comment 1

[(no longer active)]

I think this may be the bug that I was remembering with devtools... If it is that bug, before step 3 there would be no directories in $profile/storage/default, and opening Storage Inspector will create them. IIRC the reason is because DOM Cache being accessed by the Storage Inspector.

Comment 2

[Gary Chen [:xeonchen]]

Attachment: Bug 1602890 - use correct window/principal for cache; r=Ehsan,nchevobbe

• cache should use the principal of corresponding window, not top-level
• STATE_COOKIES_BLOCKED_TRACKER could happen for dFPI and should be partitioned.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1527ffd4978
use correct window/principal for cache; r=Ehsan

Comment 4

[Oana Pop-Rus]

Backed out changeset b1527ffd4978 (bug 1602890) for dt failure in browser_aboutdebugging_devtoolstoolbox_reload.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=windows%2C7%2Cdebug%2Cmochitests%2Ctest-windows7-32%2Fdebug-mochitest-devtools-chrome-e10s-5%2Cm%28dt5%29&fromchange=e687d00a3de08cb810f699d5399a443a0cc6fb3d&selectedJob=288334203

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288334203&repo=autoland&lineNumber=8744
and https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288339143&repo=autoland&lineNumber=7579

Backout: https://hg.mozilla.org/integration/autoland/rev/4de20854baecfcc76bfe54ba8c026367effe27f2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0a289821670
use correct window/principal for cache; r=Ehsan,nchevobbe

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b0a289821670