1602964 - First menuitem of menu is always highlighted

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Alice0775 White]

Attachment: image.png

Reproducible: always

Steps To Reproduce:

1. Open Add-ons Manager
2. Click three dot menu in Extensions/Themes/Plugins tab

Optionally
3. Mouse hover over the other items

Actual Results:
First menuitem of menu is always highlighted

Expected Results:
No highlighted until mouse hover or select with keyboard

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a3bc852f2ee1dde3fc84e2e88b47fe9a046d388a&tochange=a3ecf85a806affa5f3f9cc22da14aee553ef2673

Comment 1

[Mark Striemer [:mstriemer]]

This was intentional since the accessibility guidelines are to focus the first item in the menu popup when it opens. When using a screen reader I think it's common to use the shortcut that simulates a click so we can't really differentiate between a real mouse click and a screen reader mouse click. I agree it looks a little odd though.

I just poked around in gmail and phabricator with NVDA on and gmail doesn't seem to focus the first item (which I really think we want to do) but phabricator does (even though it doesn't seem to with a real mouse click). I tried to figure out what phabricator is doing but they're definitely doing something weird.

There could be some improvements to be made still, but I think it's okay for now.

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

It doesn't looks like intentional change, as all other menus (even hamburger menu) don't behave that way. What's more now with this change I'm seeing 2 items focused, first by keyboard and second by mouse, which operate independently.

Comment 3

[Mark Striemer [:mstriemer]]

Perhaps we could do something like check if the button is focused in a mousedown event and if that's the case have this behaviour. As for the two focused elements, it looks like the focus is cleared when an item is hovered, that count work as well. The related toolbar button/menu code could have some insights. Using the aria-activedescendant attribute rather than tab focus could help as well.

For now, I'd rather not regress screen reader support. I can take a look at this again once I've cleared my in progress work.

Comment 4

[Alice0775 White]

When mouse hover over the other item, but the first item is still highlighted. this is definitely BUG I think.

Comment 5

[Alice0775 White]

Screencast: https://youtu.be/tqxJCDaG5-Y

Comment 6

[Trishul]

Attachment: Bug 1602964: First menuitem of menu is always highlighted

First menuitem of menu is always highlighted

Comment 7

[Trishul]

Attachment: screencast of focus behavior

The focus is removed as soon as the mouse enters the panel.
@marl Will this be helpful?

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mixedpuppy, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Itiel]

I think this is no longer an issue?

Comment 10

[Alice0775 White]

No longer reproduce in Nightly101.0a1.