Closed
Bug 1603035
Opened 1 year ago
Closed 1 year ago
Return a function from EventEmitter.on that removes the event listener when called
Categories
(DevTools :: Shared Components, task, P3)
DevTools
Shared Components
Tracking
(firefox73 fixed)
RESOLVED
FIXED
Firefox 73
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
This can be useful if the consumer don't want to keep the target around
Assignee | ||
Comment 1•1 year ago
|
||
This will be helpful when consumers don't want to
keep the target around.
A test is added to ensure this work as expected (and
was failing if the returned function does not call
EventEmitter.off).
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae02ae71f846 Return a function from EventEmitter.on that removes the event listener when called. r=rcaliman.
Comment 3•1 year ago
|
||
Backed out 8 changesets (Bug 1566850, Bug 1603035) for causing perma bc failures in browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow.js CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281034751&repo=autoland&lineNumber=8474
Flags: needinfo?(nchevobbe)
Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e81d6fea3194 Return a function from EventEmitter.on that removes the event listener when called. r=rcaliman.
Comment 5•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in
before you can comment on or make changes to this bug.
Description
•