1603035 - Return a function from EventEmitter.on that removes the event listener when called

Status: RESOLVED FIXED

(DevTools :: Shared Components, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

This can be useful if the consumer don't want to keep the target around

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1603035 - Return a function from EventEmitter.on that removes the event listener when called. r=rcaliman.

This will be helpful when consumers don't want to
keep the target around.
A test is added to ensure this work as expected (and
was failing if the returned function does not call
EventEmitter.off).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae02ae71f846
Return a function from EventEmitter.on that removes the event listener when called. r=rcaliman.

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out 8 changesets (Bug 1566850, Bug 1603035) for causing perma bc failures in browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=281034751

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281034751&repo=autoland&lineNumber=8474

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e81d6fea3194
Return a function from EventEmitter.on that removes the event listener when called. r=rcaliman.

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e81d6fea3194