Closed Bug 1603109 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 20721 - [Rollback] Fix crash when removing a track being rolled back.

Categories

(Core :: WebRTC, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20721 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20721
Details from upstream follow.

Henrik Boström <hbos@chromium.org> wrote:

[Rollback] Fix crash when removing a track being rolled back.

Fixes https://crbug.com/1029641 and adds WPT test coverage.

Spec for removeTrack, which explicitly handles removeTrack by aborting:
https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-removetrack

Bug: 1029641
Change-Id: I2c52e6711d34e0be25fad2681457eaf1eccc8f7f
Reviewed-on: https://chromium-review.googlesource.com/1962245
WPT-Export-Revision: d2ffd8bf7431da97881b95ed7c113f9cd1b5af44

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 19 subtests

Status Summary

Firefox

OK : 1
PASS : 12
FAIL : 7

Chrome

CRASH: 1

Safari

OK : 1
PASS : 2
FAIL : 17

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webrtc/RTCPeerConnection-setRemoteDescription-rollback.html
rollback of a remote offer should keep a transceiver created by addtrack: FAIL (Safari: FAIL)
rollback of a remote offer with stream changes: FAIL (Safari: FAIL)
implicit rollback of a local offer should visit stable state and fire negotiationneeded: FAIL (Safari: FAIL)
explicit rollback of local offer should remove transceivers and transport: FAIL (Safari: FAIL)
rollback of a local offer to negotiated stable state should enable applying of a remote offer: FAIL (Safari: FAIL)
rollback of a remote offer should keep a transceiver: FAIL (Safari: FAIL)
rollback a local offer with audio direction change to negotiated stable state and then add video receiver: FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3219fc97d87f
[wpt PR 20721] - [Rollback] Fix crash when removing a track being rolled back., a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.