1603126 - Properly reject in async-storage.js

Status: RESOLVED FIXED

(DevTools :: Shared Components, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

In this file, reject is often called with 2 arguments:

reject("Error while doing X:", req.error.name);

(See devtools/shared/async-storage.js#92)

But reject only take a single argument, which means that catching those rejection would only give access to the error "message", while omitting the error name.

We can probably reject either an object with the message + the exception.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1603126 - Fix Promise rejections in async-storage. r=jdescottes.

All the rejections were called with 2 arguments, when reject only
cares about the first one.
This patch makes all the reject called with the actual DOMException,
and adds console.error before all those rejections.

Depends on D56744

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/262025967f52
Fix Promise rejections in async-storage. r=jdescottes.

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/262025967f52