1603231 - verify_processed cronrun job is broken

Status: RESOLVED FIXED

(Socorro :: General, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

When I did the boto -> boto3 rewrite for Socorro, I broke the verify_processed cronrun job. It's failing to run and kicking this error up:

<class 'AttributeError'> AttributeError("'S3' object has no attribute 'get_bucket'")

  File "/app/webapp-django/crashstats/cron/management/commands/cronrun.py", line 147, in _run_one
    self._run_job(job_spec, *cmd_args, **cmd_kwargs)
  File "/app/webapp-django/crashstats/cron/management/commands/cronrun.py", line 189, in _run_job
    job_spec["cmd"], *cmd_args, stdout=self.stdout, **cmd_kwargs
  File "/usr/local/lib/python3.7/site-packages/django/core/management/__init__.py", line 148, in call_command
    return command.execute(*args, **defaults)
  File "/usr/local/lib/python3.7/site-packages/django/core/management/base.py", line 364, in execute
    output = self.handle(*args, **options)
  File "/app/webapp-django/crashstats/crashstats/management/commands/verifyprocessed.py", line 178, in handle
    self.check_past_missing()
  File "/app/webapp-django/crashstats/crashstats/management/commands/verifyprocessed.py", line 149, in check_past_missing
    bucket = s3_client.get_bucket(bucket_name)
  File "/usr/local/lib/python3.7/site-packages/botocore/client.py", line 516, in __getattr__
    self.__class__.__name__, item)

I think it's this sentry error, but it's really hard to tell since sentry is truncating the message:

https://sentry.prod.mozaws.net/operations/socorro-new-prod/issues/5864397/

This bug covers fixing that.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing to do now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5057: bug 1603231: fix verifyprocessed

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5057: "bug 1603231: fix verifyprocessed" in 36bb504.

I'll verify this on stage tomorrow.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was deployed in bug #1603593 just now. Marking as FIXED.