1603240 - Crash in [@ neqo_transport::send_stream::TxBuffer::mark_as_acked]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[[e-mail]]

This bug is for crash report bp-63285095-ef8e-4a6d-afe9-52b400191211.

As requested by [:cpeterson] in https://bugzilla.mozilla.org/show_bug.cgi?id=1601997, I created a separate bug for this crash report.

Using Firefox 72.0b5, crashed on a HTTP/3 site hosted by cloudflare. Manually switched network.http.http3.enabled to true.

Top 10 frames of crashing thread:

0 XUL RustMozCrash mozglue/static/rust/wrappers.cpp:17
1 XUL mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 XUL core::ops::function::Fn::call src/libcore/ops/function.rs:69
3 XUL std::panicking::rust_panic_with_hook src/libstd/panicking.rs:481
4 XUL std::panicking::begin_panic src/libstd/panicking.rs:411
5 XUL neqo_transport::send_stream::TxBuffer::mark_as_acked 
6 XUL neqo_transport::connection::Connection::input_frame 
7 XUL neqo_transport::connection::Connection::process_input 
8 XUL neqo_http3conn_process_input netwerk/socket/neqo_glue/src/lib.rs:154
9 XUL mozilla::net::Http3Session::ProcessInput netwerk/protocol/http/Http3Session.cpp:203

Comment 1

[Chris Peterson [:cpeterson]]

All crash reports are from Firefox 72.0a1 and 72.0b. Unclear whether this bug has been fixed in 73.0a1 (perhaps from updating to neqo 0.1.6 in bug 1596069) or is just super low volume.

https://crash-stats.mozilla.com/search/?signature=~neqo_transport%3A%3Asend_stream%3A%3ATxBuffer%3A%3Amark_as_acked&date=%3E%3D2019-06-11T21%3A49%3A00.000Z&date=%3C2019-12-11T21%3A49%3A00.000Z&_facets=signature&_facets=cpu_arch&_facets=version&_facets=platform_pretty_version&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-version

Comment 2

[Andy Grover [:grover]]

I think this bug is still present in upstream Neqo, and I just happened to fix it. Expect it to be resolved here when we import Neqo 0.1.8.

Comment 3

[[e-mail]]

Just tried it with 72b8 and got lots of these mark_as_acked crashes, but also a different one.

https://crash-stats.mozilla.org/report/index/cb446729-0cd2-4796-b1f8-c64ff0191218

Comment 4

[[e-mail]]

So, little update now that I'm on Fx 72.0b10.

I haven't crashed with b9 or b10 yet, but I think that is because Fx likes to use HTTP/2 a lot more lately even though the flag is on in about:config.

DevTools says HTTP/2 most of the time and only sometimes HTTP/3.

When it uses HTTP/3 it still sloooooow tho.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

http3 is disabled by default.