Support fix suggestions on Phabricator
Categories
(Conduit :: Phabricator, enhancement)
Tracking
(Not tracked)
People
(Reporter: marco, Unassigned)
References
Details
(Keywords: conduit-triaged, conduit-upstream, conduit-upstream-fixed)
We have some checkers which provide or could provide fix suggestions. We'd like to have something similar to GitHub 1.
The best solution would be if Phabricator upstream could support this. Related discussions at [2] and [3].
If it can't be supported upstream, we could build this ourselves, but the UI wouldn't be great.
- Our bot would show a suggestion in an inline comment, with a link to apply the suggestion.
- The link would point to our frontend, which would communicate with our backend to apply the suggestion to the patch, create a new diff, and update the revision to use the new diff.
Another thing to figure out is how developers will incorporate these changes locally, should they need to make further modifications on top of them. In my experience on GitHub, I've usually applied the suggestions as a last step before landing, so this was not a problem for me. I'm not sure how most people use this feature though, so it might be important to support well this use case.
[2] https://secure.phabricator.com/T10584
[3] https://secure.phabricator.com/D14104
Description
•