1603313 - Various minor cleanups.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Emilio Cobos Álvarez (:emilio)]

I had accumulated these in my tree, so probably time to land them.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1603313 - Remove some silly patterns. r=bzbarsky

foo ? true : false

or:

foo ? false : true

Have always a nicer way to be written.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1603313 - Subdocument enum callbacks should take a reference. r=bzbarsky

As they can never take null.

Depends on D56842

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1603313 - Make style images and CSS loader not track a docgroup. r=bzbarsky

This was done when all the runnable labelling stuff was going on. I don't think
this is useful anymore and shrinks our structs a bit.

Depends on D56843

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d35e6f2c8e2a
Remove some silly patterns. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/214e4ce5d2df
Subdocument enum callbacks should take a reference. r=bzbarsky

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d35e6f2c8e2a
https://hg.mozilla.org/mozilla-central/rev/214e4ce5d2df

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9115348 [details]
Bug 1603313 - Remove some silly patterns. r=bzbarsky

Beta/Release Uplift Approval Request

• User impact if declined: None (yet).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: N/A
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor refactoring that blocks other uplifts.
• String changes made/needed: none

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: We want to land other uplifts on top that depend on these patches.
• User impact if declined: N/A
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor refactoring that blocks other uplifts.
• String or UUID changes made by this patch: none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9115348 [details]
Bug 1603313 - Remove some silly patterns. r=bzbarsky

approved for 72.0b8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c308db8c9ec1
https://hg.mozilla.org/releases/mozilla-beta/rev/c06610416f0f

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e39f7a214f0e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9115348 [details]
Bug 1603313 - Remove some silly patterns. r=bzbarsky

Cleanup needed for some other uplifts. Approved for 68.4esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/44d4ad1319da
https://hg.mozilla.org/releases/mozilla-esr68/rev/d3ec0942b04a