Closed Bug 1603313 Opened 1 year ago Closed 1 year ago

Various minor cleanups.

Categories

(Core :: DOM: Core & HTML, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox-esr68 72+ fixed
firefox71 --- wontfix
firefox72 --- fixed
firefox73 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(2 files, 1 obsolete file)

I had accumulated these in my tree, so probably time to land them.

foo ? true : false

or:

foo ? false : true

Have always a nicer way to be written.

As they can never take null.

Depends on D56842

This was done when all the runnable labelling stuff was going on. I don't think
this is useful anymore and shrinks our structs a bit.

Depends on D56843

Attachment #9115350 - Attachment is obsolete: true
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d35e6f2c8e2a
Remove some silly patterns. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/214e4ce5d2df
Subdocument enum callbacks should take a reference. r=bzbarsky
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

Comment on attachment 9115348 [details]
Bug 1603313 - Remove some silly patterns. r=bzbarsky

Beta/Release Uplift Approval Request

  • User impact if declined: None (yet).
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: N/A
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Minor refactoring that blocks other uplifts.
  • String changes made/needed: none

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: We want to land other uplifts on top that depend on these patches.
  • User impact if declined: N/A
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Minor refactoring that blocks other uplifts.
  • String or UUID changes made by this patch: none
Attachment #9115348 - Flags: approval-mozilla-esr68?
Attachment #9115348 - Flags: approval-mozilla-beta?
Attachment #9115349 - Flags: approval-mozilla-beta?
Attachment #9115349 - Flags: approval-mozilla-esr68?

Comment on attachment 9115348 [details]
Bug 1603313 - Remove some silly patterns. r=bzbarsky

approved for 72.0b8

Attachment #9115348 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9115349 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9115348 [details]
Bug 1603313 - Remove some silly patterns. r=bzbarsky

Cleanup needed for some other uplifts. Approved for 68.4esr.

Attachment #9115348 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
Attachment #9115349 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
You need to log in before you can comment on or make changes to this bug.