Closed Bug 1603461 Opened 3 years ago Closed 3 years ago

Add support for extended attributes on nullable types

Categories

(Core :: DOM: Bindings (WebIDL), enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

Right now we don't support having extended attributes on nullable types in WebIDL, for example, [Clamp] octet? foo will throw an error at https://searchfox.org/mozilla-central/rev/62a130ba0ac80f75175e4b65536290b52391f116/dom/bindings/parser/WebIDL.py#2246

We need to support it for https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.12 which has [AllowShared] ArrayBufferView? pixels in method arguments.

Blocks: 1575425
Priority: -- → P1
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f911e3de6e53
Add support for extended attributes on nullable types; r=bzbarsky

Backed out changeset f911e3de6e53 (bug 1603461) for eslint in test_attributes_on_types.html

Backout: https://hg.mozilla.org/integration/autoland/rev/603b256782f870fe74e8e81304789fdf27c49190

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f911e3de6e53869f12165dd95b6ac095cd919330

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281441263&repo=autoland&lineNumber=294

[vcs 2019-12-16T22:09:12.891Z] 285293 files updated, 0 files merged, 0 files removed, 0 files unresolved
[vcs 2019-12-16T22:09:13.238Z] updated to f911e3de6e53869f12165dd95b6ac095cd919330
[vcs 2019-12-16T22:09:13.243Z] PERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "clone", "serverUrl": "us-west-2.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 171.3304798603058}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "update", "serverUrl": "us-west-2.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 108.47448801994324}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "overall", "serverUrl": "us-west-2.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 280.2323172092438}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "overall_clone", "serverUrl": "us-west-2.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 280.2323172092438}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "overall_clone_fullcheckout", "serverUrl": "us-west-2.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 280.2323172092438}]}
[vcs 2019-12-16T22:09:13.530Z] TinderboxPrint:<a href=https://us-west-2.hgmointernal.net/integration/autoland/rev/f911e3de6e53869f12165dd95b6ac095cd919330 title='Built from autoland revision f911e3de6e53869f12165dd95b6ac095cd919330'>f911e3de6e53869f12165dd95b6ac095cd919330</a>
[setup 2019-12-16T22:09:13.530Z] GECKO_PATH is /builds/worker/checkouts/gecko
[task 2019-12-16T22:09:13.530Z] executing ['bash', '-cx', 'cp -r /build/node_modules_eslint node_modules && ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules && ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules && ./mach lint -l eslint -f treeherder --quiet -f json:/builds/worker/mozlint.json\n']in /builds/worker/checkouts/gecko
[task 2019-12-16T22:09:13.533Z] + cp -r /build/node_modules_eslint node_modules
[task 2019-12-16T22:09:13.931Z] + ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules
[task 2019-12-16T22:09:13.933Z] + ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules
[task 2019-12-16T22:09:13.933Z] + ./mach lint -l eslint -f treeherder --quiet -f json:/builds/worker/mozlint.json
[task 2019-12-16T22:09:15.573Z] Using base prefix '/usr'
[task 2019-12-16T22:09:15.573Z] New python executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/bin/python3
[task 2019-12-16T22:09:15.573Z] Also creating executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/bin/python
[task 2019-12-16T22:09:15.574Z] Installing setuptools, pip, wheel...
[task 2019-12-16T22:09:18.240Z] done.
[task 2019-12-16T22:09:19.594Z] b"running build_ext\nbuilding 'psutil._psutil_linux' extension\ncreating build\ncreating build/temp.linux-x86_64-3.5\ncreating build/temp.linux-x86_64-3.5/psutil\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_common.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_common.o\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_posix.o\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_linux.o\ncreating build/lib.linux-x86_64-3.5\ncreating build/lib.linux-x86_64-3.5/psutil\nx86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.5/psutil/_psutil_common.o build/temp.linux-x86_64-3.5/psutil/_psutil_posix.o build/temp.linux-x86_64-3.5/psutil/_psutil_linux.o -o build/lib.linux-x86_64-3.5/psutil/_psutil_linux.cpython-35m-x86_64-linux-gnu.so\nbuilding 'psutil._psutil_posix' extension\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_common.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_common.o\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_posix.o\nx86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.5/psutil/_psutil_common.o build/temp.linux-x86_64-3.5/psutil/_psutil_posix.o -o build/lib.linux-x86_64-3.5/psutil/_psutil_posix.cpython-35m-x86_64-linux-gnu.so\ncopying build/lib.linux-x86_64-3.5/psutil/_psutil_linux.cpython-35m-x86_64-linux-gnu.so -> psutil\ncopying build/lib.linux-x86_64-3.5/psutil/_psutil_posix.cpython-35m-x86_64-linux-gnu.so -> psutil\n"
[task 2019-12-16T22:09:19.594Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-12-16T22:24:33.733Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/dom/bindings/test/test_attributes_on_types.html:26:22 | 'TestFunctions' is not defined. (no-undef)
[task 2019-12-16T22:24:33.733Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/dom/bindings/test/test_attributes_on_types.html:40:22 | 'TestFunctions' is not defined. (no-undef)
[taskcluster 2019-12-16 22:24:34.177Z] === Task Finished ===
[taskcluster 2019-12-16 22:24:34.524Z] Unsuccessful task run with exit code: 1 completed in 1288.213 seconds

Flags: needinfo?(echen)
Flags: needinfo?(echen)
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/013bce7790cf
Add support for extended attributes on nullable types; r=bzbarsky
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.