Closed Bug 1603465 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20747 - LazyLoad: add WPT test for invisible in-viewport lazy images

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox73 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20747 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20747
Details from upstream follow.

Rob Buis <rbuis@igalia.com> wrote:

LazyLoad: add WPT test for invisible in-viewport lazy images

Add WPT test for invisible in-viewport lazy images and rename
old invisible-lazy-image.tentative.html to
invisible-lazy-out-of-viewport-image.tentative.html to better indicate
what the test does.

Bug: 956559
Change-Id: I26ba797fc8fcd3bd82f861c3b1578ab28fb93490
Reviewed-on: https://chromium-review.googlesource.com/1962261
WPT-Export-Revision: 7b6e7b79fd5e381a38788de19a311e0edb8a742d

PR 20747 applied with additional changes from upstream: adba2f3573f62da0d07a55b7608c2850725a325d, eb536fbabbd5bfa20798479fdba9f691a893db89

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 1
FAIL: 1[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']] 2[['GitHub']]

Chrome

OK : 2
PASS: 2

Safari

OK : 2
PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/loading/lazyload/invisible-lazy-image.tentative.html
Test behavior of in viewport invisible lazy images: FAIL (Chrome: PASS, Safari: FAIL)
/loading/lazyload/invisible-image.tentative.html
Test that below-viewport invisible images that are not marked loading=lazy still load, and block the window load event: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: PASS, Safari: PASS)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 1
FAIL: 1[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']] 2[['GitHub']]

Chrome

OK : 2
PASS: 2

Safari

OK : 2
PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/loading/lazyload/invisible-lazy-image.tentative.html
Test behavior of in viewport invisible lazy images: FAIL (Chrome: PASS, Safari: FAIL)
/loading/lazyload/invisible-image.tentative.html
Test that below-viewport invisible images that are not marked loading=lazy still load, and block the window load event: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: PASS, Safari: PASS)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 1
FAIL: 1[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']] 2[['GitHub']]

Chrome

OK : 2
PASS: 2

Safari

OK : 2
PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/loading/lazyload/invisible-lazy-image.tentative.html
Test behavior of in viewport invisible lazy images: FAIL (Chrome: PASS, Safari: FAIL)
/loading/lazyload/invisible-image.tentative.html
Test that below-viewport invisible images that are not marked loading=lazy still load, and block the window load event: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbe76f8bc6cc
[wpt PR 20747] - LazyLoad: add WPT test for invisible in-viewport lazy images, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2a62011237e5
[wpt PR 20747] - Update wpt metadata, a=testonly

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 1
FAIL: 1[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']] 2[['GitHub']]

Chrome

OK : 2
PASS: 2

Safari

OK : 2
PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/loading/lazyload/invisible-lazy-image.tentative.html
Test behavior of in viewport invisible lazy images: FAIL (Chrome: PASS, Safari: FAIL)
/loading/lazyload/invisible-image.tentative.html
Test that below-viewport invisible images that are not marked loading=lazy still load, and block the window load event: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: PASS, Safari: PASS)

Test result changes from PR not available.
Regressions: 1605093

https://hg.mozilla.org/mozilla-central/rev/bbe76f8bc6cc
https://hg.mozilla.org/mozilla-central/rev/2a62011237e5

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.