1603510 - mach try --edit-preset assumes the $EDITOR is a single command

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect, P3)

Description

[Dave Townsend [:mossop]]

My $EDITOR is code -w which every other tool handles fine. mach try syntax --edit-presets throws an error:

OSError: [Errno 2] No such file or directory

  File "/Users/dave/mozilla/source/trunk/tools/tryselect/mach_commands.py", line 410, in try_syntax
    return self.run(**kwargs)
  File "/Users/dave/mozilla/source/trunk/tools/tryselect/mach_commands.py", line 176, in run
    kwargs = self.handle_presets(**kwargs)
  File "/Users/dave/mozilla/source/trunk/tools/tryselect/mach_commands.py", line 117, in handle_presets
    user_presets.edit()
  File "/Users/dave/mozilla/source/trunk/tools/tryselect/preset.py", line 55, in edit
    subprocess.call([os.environ['EDITOR'], self.path])
  File "/usr/local/Cellar/python@2/2.7.17/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 172, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/local/Cellar/python@2/2.7.17/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 394, in __init__
    errread, errwrite)
  File "/usr/local/Cellar/python@2/2.7.17/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1047, in _execute_child
    raise child_exception

Comment 1

[Geoff Brown [:gbrown]]

Attachment: Bug 1603510 - Allow multi-word $EDITOR in 'mach try syntax --edit-presets'; r=

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33e5d8b9542a
Allow multi-word $EDITOR in 'mach try syntax --edit-presets'; r=bc

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/33e5d8b9542a