1603605 - Use higher priority messages for notifying parent browsing context about child being loaded.

Status: NEW

(Core :: DOM: Navigation, task, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Right now messages to notify that some iframe has been loaded use normal priority messages - and that means they end up being behind everything else there might be on the
normal priority queue.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1603605, Use higher priority messages for notifying parent browsing context about child being loaded

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9646033edb2f2dc2b6289ff0126ca9fa9a22b242

Comment 3

[Chris Peterson [:cpeterson]]

Tracking perf issue for Fission Nightly (M6)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1603605, Use higher priority messages for notifying parent browsing context about child being loaded

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=955f4275548f00519a2ad1a131bfdec2baded6fc

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

(the patch isn't final, but perhaps good enough for some performance testing)
base https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9bd733a69e9cb76f7eff9a6997c438334de9343
patch https://treeherder.mozilla.org/#/jobs?repo=try&revision=bee619cb04b5c6a455db9d9f78dd4c22485c0599

Comment 7

[Chris Peterson [:cpeterson]]

Olli, do you still want to land this change? Should this bug block enabling Fission in Nightly (milestone M6)?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

That patch isn't safe enough. But we probably need to do something here.

Comment 9

[Neha Kochar [:neha]]

Randell, we should keep this in mind for fission-perf and whether or not we need this right now or later.

Comment 10

[Chris Peterson [:cpeterson]]

Nika says this work doesn't need to block Fission M6 Nightly. Tracking for Fission Future because this is a speculative fix for perf issues that we don't know exist yet.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

This is not really speculative. The current setup for load event firing takes very slow paths. Easy to see in profiles.
(But certainly doesn't need to block M6)

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

What more would need to be done for this patch to land? What are the safety issues?

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

the patch changes ordering of things around loading and isn't safe as such.

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

This is tracked as part of bug 1739417 and is now just a normal performance bug.