Open Bug 1603605 Opened 3 years ago Updated 14 days ago

Use higher priority messages for notifying parent browsing context about child being loaded.

Categories

(Core :: DOM: Navigation, task, P3)

task

Tracking

()

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Whiteboard: [not-a-fission-bug])

Attachments

(1 file, 1 obsolete file)

Right now messages to notify that some iframe has been loaded use normal priority messages - and that means they end up being behind everything else there might be on the
normal priority queue.

Depends on: 1600605

Tracking perf issue for Fission Nightly (M6)

Fission Milestone: --- → M6
Summary: Use higher priority messages for notifying parent browsing context about child being loaded. → [Fission] Use higher priority messages for notifying parent browsing context about child being loaded.
Attachment #9115868 - Attachment is obsolete: true

Olli, do you still want to land this change? Should this bug block enabling Fission in Nightly (milestone M6)?

Severity: normal → S3
Flags: needinfo?(bugs)

That patch isn't safe enough. But we probably need to do something here.

Flags: needinfo?(bugs)

Randell, we should keep this in mind for fission-perf and whether or not we need this right now or later.

Flags: needinfo?(rjesup)

Nika says this work doesn't need to block Fission M6 Nightly. Tracking for Fission Future because this is a speculative fix for perf issues that we don't know exist yet.

Type: defect → task
Fission Milestone: M6 → Future
Priority: P2 → P3

This is not really speculative. The current setup for load event firing takes very slow paths. Easy to see in profiles.
(But certainly doesn't need to block M6)

What more would need to be done for this patch to land? What are the safety issues?

Flags: needinfo?(rjesup) → needinfo?(bugs)

the patch changes ordering of things around loading and isn't safe as such.

Flags: needinfo?(bugs)
Blocks: 1739417

This is tracked as part of bug 1739417 and is now just a normal performance bug.

Fission Milestone: Future → ---
Summary: [Fission] Use higher priority messages for notifying parent browsing context about child being loaded. → Use higher priority messages for notifying parent browsing context about child being loaded.
Whiteboard: [not-a-fission-bug]
You need to log in before you can comment on or make changes to this bug.