1603698 - Omniscient Browser Toolbox error when closing a tab "this._stopThreadFrontListeners is not a function"

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Julian Descottes [:jdescottes]]

The patch from Bug 1583550 landed without addressing some review comments, one of those leads to a JS error.

toolbox.js might still call this._stopThreadFrontListeners(), however the method has been removed so this will throw.

https://searchfox.org/mozilla-central/search?q=_stopThreadFrontListeners&case=false&regexp=false&path=

STRs to trigger the error

• open the OBT
• open a tab on a content page
• close the tab

console.error: (new TypeError("this._stopThreadFrontListeners is not a function", "resource://devtools/client/framework/toolbox.js", 655))
TypeError: this._stopThreadFrontListeners is not a function: _onTargetDestroyed@resource://devtools/client/framework/toolbox.js:655:12
emit@resource://devtools/shared/event-emitter.js:191:24
emit@resource://devtools/shared/event-emitter.js:272:18
_onTargetDestroyed@resource://devtools/shared/resources/target-list.js:266:28
_processListChanged@resource://devtools/shared/resources/target-list.js:40:16
Async*emit@resource://devtools/shared/event-emitter.js:191:24
emit@resource://devtools/shared/event-emitter.js:272:18
onPacket@resource://devtools/shared/protocol/Front.js:252:13
onPacket@resource://devtools/shared/client/debugger-client.js:511:13
_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22

Comment 1

[Julian Descottes [:jdescottes]]

Jason, can you address this leftover?

Comment 2

[Jason Laster [:jlast]]

Sorry Julian, looking into it now.

Comment 3

[Jason Laster [:jlast]]

Attachment: Bug 1603698 - Omniscient Browser Toolbox error "this._stopThreadFrontListeners is not a function". r=jdescottes

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/facce2d97e74
Omniscient Browser Toolbox error  "this._stopThreadFrontListeners is not a function". r=jdescottes

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/facce2d97e74