Closed
Bug 1603698
Opened 1 year ago
Closed 1 year ago
Omniscient Browser Toolbox error when closing a tab "this._stopThreadFrontListeners is not a function"
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(firefox73 fixed)
RESOLVED
FIXED
Firefox 73
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jlast)
References
Details
Attachments
(1 file)
The patch from Bug 1583550 landed without addressing some review comments, one of those leads to a JS error.
toolbox.js might still call this._stopThreadFrontListeners()
, however the method has been removed so this will throw.
STRs to trigger the error
- open the OBT
- open a tab on a content page
- close the tab
console.error: (new TypeError("this._stopThreadFrontListeners is not a function", "resource://devtools/client/framework/toolbox.js", 655))
TypeError: this._stopThreadFrontListeners is not a function: _onTargetDestroyed@resource://devtools/client/framework/toolbox.js:655:12
emit@resource://devtools/shared/event-emitter.js:191:24
emit@resource://devtools/shared/event-emitter.js:272:18
_onTargetDestroyed@resource://devtools/shared/resources/target-list.js:266:28
_processListChanged@resource://devtools/shared/resources/target-list.js:40:16
Async*emit@resource://devtools/shared/event-emitter.js:191:24
emit@resource://devtools/shared/event-emitter.js:272:18
onPacket@resource://devtools/shared/protocol/Front.js:252:13
onPacket@resource://devtools/shared/client/debugger-client.js:511:13
_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
Assignee | ||
Comment 3•1 year ago
|
||
Updated•1 year ago
|
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/facce2d97e74 Omniscient Browser Toolbox error "this._stopThreadFrontListeners is not a function". r=jdescottes
Comment 5•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in
before you can comment on or make changes to this bug.
Description
•