Closed Bug 1603758 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20768 - Added tests for meta color-scheme attribute changes.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20768 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20768
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Added tests for meta color-scheme attribute changes.

Also made HTMLMetaElement::GetName() use FastGetAttribute without
checking HasName() because HasName() is not up-to-date when
ParseAttribute() is called, which made one of the tests fail.

All tests pass with CSSColorScheme and MetaColorScheme flags enabled.

Bug: 925935
Change-Id: Ia35a656ce293874461745745ca9abb59f083a22d
Reviewed-on: https://chromium-review.googlesource.com/1967185
WPT-Export-Revision: eedeef86864bc93484aba2c127854a815d081f07

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
FAIL : 7
ERROR: 1

Chrome

OK : 1
FAIL : 7

Safari

OK : 1
FAIL : 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-color-adjust/meta/meta-color-scheme-attribute-changes.html: ERROR [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], OK [GitHub] (Chrome: OK, Safari: OK)
Removed name attribute from meta color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to empty string.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to 'light'.: FAIL (Chrome: FAIL, Safari: FAIL)
Removed the content attribute of meta color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Set meta name to color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Meta color-scheme initially 'dark'.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to an invalid value.: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
FAIL : 7
ERROR: 1

Chrome

OK : 1
FAIL : 7

Safari

OK : 1
FAIL : 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-color-adjust/meta/meta-color-scheme-attribute-changes.html: ERROR [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], OK [GitHub] (Chrome: OK, Safari: OK)
Removed name attribute from meta color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to empty string.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to 'light'.: FAIL (Chrome: FAIL, Safari: FAIL)
Removed the content attribute of meta color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Set meta name to color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Meta color-scheme initially 'dark'.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to an invalid value.: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
FAIL : 7
ERROR: 1

Chrome

OK : 1
FAIL : 7

Safari

OK : 1
FAIL : 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-color-adjust/meta/meta-color-scheme-attribute-changes.html: ERROR [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], OK [GitHub] (Chrome: OK, Safari: OK)
Removed name attribute from meta color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to empty string.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to 'light'.: FAIL (Chrome: FAIL, Safari: FAIL)
Removed the content attribute of meta color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Set meta name to color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Meta color-scheme initially 'dark'.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to an invalid value.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a18febba879
[wpt PR 20768] - Added tests for meta color-scheme attribute changes., a=testonly
https://hg.mozilla.org/integration/autoland/rev/4d106aec5abf
[wpt PR 20768] - Update wpt metadata, a=testonly

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
FAIL : 7
ERROR: 1

Chrome

OK : 1
FAIL : 7

Safari

OK : 1
FAIL : 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-color-adjust/meta/meta-color-scheme-attribute-changes.html: ERROR [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], OK [GitHub] (Chrome: OK, Safari: OK)
Removed name attribute from meta color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to empty string.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to 'light'.: FAIL (Chrome: FAIL, Safari: FAIL)
Removed the content attribute of meta color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Set meta name to color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Meta color-scheme initially 'dark'.: FAIL (Chrome: FAIL, Safari: FAIL)
Set content attribute of meta color-scheme to an invalid value.: FAIL (Chrome: FAIL, Safari: FAIL)

Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/0a18febba879
https://hg.mozilla.org/mozilla-central/rev/4d106aec5abf

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.