1603786 - Context menu arrow symbols sometimes desync with hover state

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect, P3)

Description

[nightpool]

Attachment: menu hover.mp4

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

1. open Developer Tools, navigate to the "Inspector" tab
2. right click on an element
3. move your mouse up and down the menu
4. Notice that most of the time, when you hover a menu item, both the text color and the color of any symbols in that item change

Actual results:

Sometimes, the color of the symbols in a menu item gets out of sync with the text color (e.g., showing a white arrow when the item isn't hovered, or a black "checked" symbol when the item is hovered). This happens maybe 20% of the time. (see attached screen recording)

Expected results:

The color of the symbol should be in sync with the text color

Comment 1

[nightpool]

Attachment: firefox about:support json

Comment 2

[Patrick Brosset <:pbro>]

Thanks for filing, I was able to reproduce the issue outside of DevTools too by doing this:

• right-click anywhere on the web page
• move your mouse over the menu items in the context menu until the submenu arrow turns white.

Note: this is on macOS 10.14, with Firefox 72.

I believe it is appropriate for the XUL team to investigate this issue.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:bgrins, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Brian Grinstead [:bgrins]]

I haven't been able to reproduce this personally, but I can poke around at the styles in the Browser Toolbox and

For the text we have something like this: menu[_moz-menuactive="true"] { color: -moz-mac-menutextselect; }.

And then inside that there is an hbox.menu-right that renders the arrow like this: -moz-appearance: menuarrow. Changing the CSS color on that element doesn't seem to change anything, which makes me think there is something going wrong in the widget (like maybe a timing issue with the CheckBooleanAttr(aFrame, nsGkAtoms::menuactive) check in https://searchfox.org/mozilla-central/rev/cfd1cc461f1efe0d66c2fdc17c024a203d5a2fd8/widget/cocoa/nsNativeThemeCocoa.mm#1097. Tentatively moving to Widget::Cocoa because of that

Comment 5

[Josh Aas]

I think this was happening prior to the switch to native context menus. So far as I know native context menus don't have this problem.