Closed Bug 1603890 Opened 1 year ago Closed 1 year ago

Include dynamic-process keyed scalars in telemetry pings

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement
Points:
1

Tracking

()

RESOLVED FIXED
mozilla73
Iteration:
73.2 - Dec 16 - Jan 5
Tracking Status
firefox72 --- fixed
firefox73 --- verified

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Keyed scalars aren't included in pings for the dynamic process, only non-keyed scalars: https://searchfox.org/mozilla-central/rev/2f09184ec781a2667feec87499d4b81b32b6c48e/toolkit/components/telemetry/pings/TelemetrySession.jsm#686

I'm working on two experiment add-ons that record keyed scalars. Can we just add them? I'm wondering if it's because the webextension telemetry API didn't support keyed scalars until very recently?

If adding them is a problem for some reason, I could probably switch to non-keyed scalars...

Flags: needinfo?(chutten)
Flags: needinfo?(chutten)
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d47b43f4ab5
Include dynamic-process keyed scalars in telemetry pings r=chutten
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

Comment on attachment 9115899 [details]
Bug 1603890 - Include dynamic-process keyed scalars in telemetry pings

Beta/Release Uplift Approval Request

  • User impact if declined: We need this in order to run two urlbar experiments on 72 as planned (bug 1568594, bug 1564506).
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a one-line change that adds keyed scalars from the "dynamic" process (i.e., add-ons) to the telemetry ping. Please note that I chose "yes" for the question about automated tests -- this code has tests generally but this patch specifically doesn't have a test.
  • String changes made/needed:
Attachment #9115899 - Flags: approval-mozilla-beta?

Comment on attachment 9115899 [details]
Bug 1603890 - Include dynamic-process keyed scalars in telemetry pings

approved for 72.0b8

Attachment #9115899 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have tested this issue and is no longer reproducible on the latest Nightly 73.0a1 build (Build ID: 20191216214733). Tested on Windows 7 x64, Mac 10.15 and Ubuntu 18.04.

In order to verify this I have used the Search Interventions add-on. The "urlbarInterventionsExperiment.tipShownCount" and "urlbarInterventionsExperiment.tipPickedCount" dynamic keyed scalars are registered and displayed after the browser restart in "Archived ping data". I have also verified this using a local telemetry server and the mentioned keyed scalars are sent to the local server.

You need to log in before you can comment on or make changes to this bug.