1603964 - Triple click selection breaks at inline-block boundaries

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect, P3)

Description

[Sid Vishnoi :sidvishnoi]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Input:

<p><code>oops</code> triple click me to select this sentence <code>hey!</code>.</p>
<style>code { display: inline-block; }</style>

• Triple click the "triple click me to select this sentence" part.

Actual results:

• Triple clicking selected/highlighted only "triple click me to select this sentence" part, and skipped "oops" and "hey!".

See for a minimal example: https://codepen.io/sidvishnoi/pen/zYxKRKK
Platform: Linux x64 (Ubuntu)

• Firefox 73 (Nightly), Firefox 71: doesn't select "oops", "hey".
• Chrome 79: selects.

Expected results:

Entire paragraph should have been selected, regardless of code being inline or inline-block

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I think we should treat inline-blocks with a single line as inlines. Thoughts Mats?

Comment 2

[Mats Palmgren (inactive)]

That seems reasonable. The behavior in Chrome is a bit more subtle actually. Modifying the test to <code>oops<br>last</code> it seems that Chrome extends the selection to include "last" but not "oops". Likewise, triple-clicking "last" works the same, but triple-clicking "oops" selects just that line inside the inline-block. (Adding vertical-align:top make no difference, which is a bit more debatable whether it makes sense or not.)
But yeah, including single-line inline-blocks as you suggest seems like a good first step.

Comment 3

[Mats Palmgren (inactive)]

For the record, changing the last inline-block to <code>hey!<br>again</code> shows that Chrome includes "hey!" but not "again". I.e. the opposite of how it works on the start side. I guess not supporting multi-range selection makes it impossible for them to select "again" without also selecting "hey!".

Comment 4

[Mats Palmgren (inactive)]

Is there any arguments for why we simply shouldn't include the whole inline-block even if it's multiple lines? It's clearly part of the line it's displayed on, so I can't think of a good reason for Chrome's behavior.

If you move the inline-block to the middle of the line, then Chrome stops the selection there. That behavior seems weird to me.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

The only weird thing that comes to mind is what line to select when you triple-click in an inline-block with multiple lines... If you only account single-line inline-blocks then the answer seems straight-forward but... I don't feel very strongly either way.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1603964 - Only treat block-level frames as line-breaks in paragraph selection code. r=mats

Comment 8

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e83989312fa3653bc0dadd2ed78601ac6a3a3987

Comment 9

[Mats Palmgren (inactive)]

Attachment: Testcase #1

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/476a32323adb
Only treat block-level frames as line-breaks in paragraph selection code. r=mats

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/476a32323adb

Comment 12

[Alexandru Trif, Desktop QA [:atrif]]

Reproduced the issue with Firefox 73.0a1 (20191214215837) using STR from comment 0 and test case from comment 9 on Windows 10x64.
The issue is verified fixed with Firefox 74.0b4 (20200216164042) on Windows 10x64, macOS 10.15 and Ubuntu 16.04.